New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639100 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

ASSERT failure in isAllowedToQueryCompositingState()

Project Member Reported by thestig@chromium.org, Aug 18 2016

Issue description

Version: r412900
OS: Linux

What steps will reproduce the problem?
(1) In a debug build, load http://www.anth.ucsb.edu/faculty/gurven/papers/GurvenKaplan2007pdr.pdf
(2) Hold down the PgDown key for a couple seconds. Let go of the key.
(3) Wait a few seconds
(4) Press the Up key.

ASSERTION FAILED: isAllowedToQueryCompositingState()
../../third_party/WebKit/Source/core/paint/PaintLayer.cpp(2270) : blink::CompositingState blink::PaintLayer::compositingState() const
1   0x7fa9464f932a blink::PaintLayer::compositingState() const
2   0x7fa946490403 blink::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(blink::FrameView*) const
3   0x7fa94648d2a0 blink::ScrollingCoordinator::mainThreadScrollingReasons() const
4   0x7fa946240765
5   0x7fa94622e031 blink::FrameView::shouldScrollOnMainThread() const
6   0x7fa950e64fbb blink::ScrollAnimator::willAnimateToOffset(blink::FloatPoint const&)
7   0x7fa950e64b2b blink::ScrollAnimator::userScroll(blink::ScrollGranularity, blink::FloatSize const&)
8   0x7fa94629b2da blink::RootFrameViewport::userScroll(blink::ScrollGranularity, blink::FloatSize const&)
9   0x7fa946787286 blink::LayoutView::scroll(blink::ScrollGranularity, blink::FloatSize const&)
10  0x7fa945b20817 blink::ScrollManager::logicalScroll(blink::ScrollDirection, blink::ScrollGranularity, blink::Node*, blink::Node*)
11  0x7fa945b20923 blink::ScrollManager::bubblingScroll(blink::ScrollDirection, blink::ScrollGranularity, blink::Node*, blink::Node*)
12  0x7fa945b00a3e blink::EventHandler::bubblingScroll(blink::ScrollDirection, blink::ScrollGranularity, blink::Node*)
13  0x7fa9506e928a blink::WebViewImpl::scrollViewWithKeyboard(int, int)

See also bug 458676.
 
Components: -Internals>Plugins>PDF Blink>Paint Blink>Scroll
Status: Available (was: Untriaged)
Cc: bokan@chromium.org
Labels: Hotlist-Input-Dev
Owner: ymalik@chromium.org
Status: Assigned (was: Available)
ymalik@ is this something that you can fix?

Comment 3 by falken@chromium.org, Aug 31 2016

Labels: -Pri-3 Pri-2
I also hit this by logging into Facebook and hitting page down a couple times.

It makes it difficult to use debug/dcheck enabled builds on Facebook.

ASSERTION FAILED: isAllowedToQueryCompositingState()
../../third_party/WebKit/Source/core/paint/PaintLayer.cpp(2284) : blink::CompositingState blink::PaintLayer::compositingState() const
1   0x7f61a106b23d blink::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(blink::FrameView*) const
2   0x7f61a1067ef6 blink::ScrollingCoordinator::mainThreadScrollingReasons() const
3   0x7f61a0ed888f blink::FrameView::shouldScrollOnMainThread() const
4   0x7f61a8a91385 blink::ScrollAnimator::willAnimateToOffset(blink::FloatPoint const&)
5   0x7f61a8a91168 blink::ScrollAnimator::userScroll(blink::ScrollGranularity, blink::FloatSize const&)
6   0x7f61a0f206cd blink::RootFrameViewport::userScroll(blink::ScrollGranularity, blink::FloatSize const&)
7   0x7f61a126bff7 blink::LayoutView::scroll(blink::ScrollGranularity, blink::FloatSize const&)
8   0x7f61a0a42da4 blink::ScrollManager::logicalScroll(blink::ScrollDirection, blink::ScrollGranularity, blink::Node*, blink::Node*)
9   0x7f61a0a42e8e blink::ScrollManager::bubblingScroll(blink::ScrollDirection, blink::ScrollGranularity, blink::Node*, blink::Node*)
10  0x7f61a8721c9c blink::WebViewImpl::scrollViewWithKeyboard(int, int)
11  0x7f61a8720372 blink::WebViewImpl::keyEventDefault(blink::WebKeyboardEvent const&)
12  0x7f61a871ff29 blink::WebViewImpl::handleKeyEvent(blink::WebKeyboardEvent const&)

I can hit this easily by going to this following link and hitting page up/down several times:
http://edition.cnn.com/2016/09/05/politics/philippines-president-rodrigo-duterte-barack-obama/


Cc: schenney@chromium.org

Comment 6 by ymalik@chromium.org, Sep 12 2016

looking into this..
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2153328998af9d61ff8d7743a2f5bc74f889e7f3

commit 2153328998af9d61ff8d7743a2f5bc74f889e7f3
Author: ymalik <ymalik@chromium.org>
Date: Wed Sep 14 17:07:33 2016

Query compositing state only from UpdateAnimationState

https://codereview.chromium.org/2029323003 attempted to add an optimization
that would run an animation on the MT by querying m_scrollableArea->
shouldScrollOnMainThread. This was wrong because we were querying compositing
state outside of the CompositingClean state.

This reverts that CL.

The original bug was not fixed in the CL that this reverts and that CL was
just wrong.

This CL doesn't have a behavioral change.

BUG= 639100 

Review-Url: https://codereview.chromium.org/2338913002
Cr-Commit-Position: refs/heads/master@{#418596}

[modify] https://crrev.com/2153328998af9d61ff8d7743a2f5bc74f889e7f3/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
[modify] https://crrev.com/2153328998af9d61ff8d7743a2f5bc74f889e7f3/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

Comment 8 by ymalik@chromium.org, Sep 14 2016

Status: Fixed (was: Assigned)

Sign in to add a comment