New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639080 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Autotest] Web UI locks Image/Build field even when validation errors occur

Project Member Reported by jgiorgi@chromium.org, Aug 18 2016

Issue description

On the Create Job page of the Autotest Web UI the Image/Build field is automatically locked (cannot edit, cannot select) when the form is submitted even if when validation errors occur on the form (whether the error is in that field or not). This means that a user that makes an error in the Image/Build field must complete the entire form again.

 
Is it necessary to ever lock that field? I find it irritating that I can't change the build when cloning.

Comment 2 by dshi@chromium.org, Aug 18 2016

Cc: ntang@chromium.org
+ntang

The lock on image is to prevent some unexpected behavior when image in that text box is different from the control file. That might be changed though. Michael was working on a similar change.

Comment 3 by ntang@google.com, Aug 18 2016

I fixed the  issue 485813 , when the image/build field is locked and empty when cloning a job. With the fix, in theory we are able to change the image/build now since it is passed as parameter to the server now. However, for saftey, we still lock it.

In this case when you create a new job, if validation failed, I would assume no new job created in the databsae. We should not lock any fields. Maybe you could add the specific steps to reproduce the issue. 

I don't think we will do job editing though.

Comment 4 by iannu...@google.com, Aug 19 2016

Components: -Infra Infra>Client>ChromeOS
I believe this is a chromeos infra issue?

Comment 5 by aut...@google.com, Aug 23 2016

Justin, can you add in steps to reproduce? 

Comment 6 by aut...@google.com, Aug 30 2016

Owner: jgiorgi@chromium.org
Justin, can you add steps to repro?

Comment 7 by jgiorgi@google.com, Sep 26 2016

1) Go to the Create Job form
2) Enter a name
3) Select Server side tests
4) Select test_suite:dummy
5) Fill in a bogus build such as 'foo/bar/LATEST'
Status: Archived (was: Untriaged)
This bug has not been touched in over a year.  It is probably no longer relevant.

Sign in to add a comment