Issue metadata
Sign in to add a comment
|
ExtensionDialogUiTest.TabFocusLoop is flaky on Windows |
||||||||||||||||||||||
Issue descriptionThis test has recently started occasionally failing on a few Windows 7 bots: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/56347 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/51841 https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15757 Failure log: [ RUN ] ExtensionDialogUiTest.TabFocusLoop [4560:5572:0818/113632:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [5260:5656:0818/113633:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! e:\c\site_isolation_win\src\chromerowser\ui iews\extensions\extension_dialog_interactive_uitest.cc(45): error: Value of: ui_controls::SendKeyPress( browser()->window()->GetNativeWindow(), ui::VKEY_TAB, false, false, false, false) Actual: false Expected: true [6112:6008:0818/113633:ERROR:node_channel.cc(856)] Failed to duplicate one or more outgoing handles. [6112:6008:0818/113633:ERROR:node_channel.cc(856)] Failed to duplicate one or more outgoing handles. [6112:4952:0818/113633:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] ExtensionDialogUiTest.TabFocusLoop, where TypeParam = and GetParam() = (1190 ms) Looking at the CLs in the blamelist, it's not immediately obvious what might've caused this. fukino@: do you mind triaging this, since you wrote the original test?
,
Aug 18 2016
I'll land a CL to disable this on Windows for now.
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61f9069b46b9a41c04da869a93a21903ca072a58 commit 61f9069b46b9a41c04da869a93a21903ca072a58 Author: alexmos <alexmos@chromium.org> Date: Thu Aug 18 21:47:30 2016 Disable ExtensionDialogUiTest.TabFocusLoop on Windows due to being flaky. BUG= 639072 TBR=fukino@chromium.org Review-Url: https://codereview.chromium.org/2260633003 Cr-Commit-Position: refs/heads/master@{#412941} [modify] https://crrev.com/61f9069b46b9a41c04da869a93a21903ca072a58/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc
,
Aug 18 2016
This has also been causing failures on win_chromium_x64_rel_ng, e.g.: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/264374
,
Aug 18 2016
,
Aug 26 2016
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad9e8df04eeb520cba3caae93b6fde9e1f77c99f commit ad9e8df04eeb520cba3caae93b6fde9e1f77c99f Author: Greg Thompson <grt@chromium.org> Date: Wed Nov 22 13:21:08 2017 Enable interactive_ui_tests on Windows that now run mostly reliably. r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG= 639072 , 764415 This CL was uploaded by git cl split. R=finnur@chromium.org Change-Id: Ia165545395e8b1a2826508e759e11ce6777b7f1e Reviewed-on: https://chromium-review.googlesource.com/784939 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#518621} [modify] https://crrev.com/ad9e8df04eeb520cba3caae93b6fde9e1f77c99f/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alex...@chromium.org
, Aug 18 2016