Codesearch bots should clobber if they index generated files. |
|||||
Issue descriptionCodesearch bots should clobber if they index generated files. CodeSearch can sometimes show generated files from deleted source files. For example, this landed last week: https://codereview.chromium.org/2235493002/ That CL removed the file ash/public/interfaces/shelf_layout.mojom *.mojom files generate a fair number of language-specific files. Codesearch now shows the generated files, despite not showing the source file: https://cs.chromium.org/search/?q=shelf_layout.mojom lists: src/out/Debug/gen/ash/public/interfaces/shelf_layout.mojom.h src/out/Debug/gen/ash/public/interfaces/shelf_layout.mojom.cc src/out/Debug/gen/ash/public/interfaces/shelf_layout.mojom.js src/out/Debug/gen/ash/public/interfaces/shelf_layout.mojom-internal.h src/out/Debug/gen/ash/public/interfaces/shelf_layout.mojom.srcjar It seems like clobbers were removed in https://codereview.chromium.org/909883005 Perhaps we should run periodic clobbers, if we don't want to clobber every build.
,
Aug 19 2016
> Another option would be to directly index from GoB and not index generated files at all. A naive question: what is GoB? IMO indexing generated files is very useful. One example is the mojo generated files. People sometimes want to refer to the generated files for the C++/Java/Javascript interfaces generated from IDL.
,
Aug 22 2016
> what is GoB? GoB is the git hosting that's behind chromium.googlesource.com (go/gob). We're moving to indexing Git directly, and having codesearch actually get directory listings and file contents directly from the Git servers to avoid the latency from this indexing pipeline. I wasn't planning to include generated files at all, but if it's important to people then we should maybe rethink that.
,
Aug 22 2016
> I wasn't planning to include generated files at all, but if it's important to people then we should maybe rethink that. Thanks for the reply! As you probably know, mojo is replacing the old chrome IPC system. In mojo, we define interfaces in IDLs and generate C++ interfaces from them. Without indexing the generated files, can the tool figure out that the client of a mojo interface and the corresponding service are actually referring to the same interface? (i.e., when I click on a client method call, I wish the code search tool can tell me where this interface is implemented.)
,
Sep 15 2016
,
Sep 15 2016
I think inclusion of generated files is needed to provide missing Xrefs (https://bugs.chromium.org/p/chromium/issues/detail?id=634202).
,
Jul 6 2017
,
Apr 24 2018
I don't have the full context of when this bug was created, but I'm pretty sure this is obsolete now. We copy generated files into a Git repo indexed by CS, and we do this using rsync --delete-delay, so stale generated files should no longer be a problem. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by akuegel@chromium.org
, Aug 19 2016