New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 639051 link

Starred by 1 user
Status: Duplicate
Merged: issue 602906
Owner:
█ andyb...@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
hinoka@chromium.org
tandrii@chromium.org
estaab@chromium.org
aga...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Infra tryjobs bot_update doesn't apply DEPS patches before running gclient sync

Project Member Reported by aga...@chromium.org, Aug 18 2016 
What steps will reproduce the problem?
(1) Upload a DEPS roll to infra.git (like https://chromium-review.googlesource.com/c/372078/1)
(2) Run the tryjobs (like https://luci-milo.appspot.com/swarming/task/30b7b34141fd0a10)
(3) Look at the gclient json (like https://luci-milo.appspot.com/swarming/task/30b7b34141fd0a10/steps/bot_update/0/logs/json.output/0)

What is the expected output?
The hash for the rolled repository should be the post-roll value. (In this case, 86e917c99f25e9b421716d599ceeb5282e5de583)

What do you see instead?
The hash for the rolled repository hasn't changed. (In this case, it is still cca3a7f6fe042a3f745d40176b567a6bea75c6a1)

Comment 1 by hinoka@chromium.org, Aug 18 2016

Cc: tandrii@chromium.org
Owner: phajdan.jr@chromium.org
Oh it's a gerrit patch, pawel wrote that pipeline.

Comment 2 by tandrii@chromium.org, Aug 18 2016 

Nope, Pawel patch was reverted, and this itself is KI, i'll find a dup.

Comment 3 by aga...@chromium.org, Aug 18 2016

Components: Infra>CQ
Labels: -Pri-3 OS-All Pri-1
Status: Assigned (was: Untriaged)
Putting this in the right component and at Pri-1 because this needs to be fixed before we land any more rolls in infra.git.

Comment 4 by tandrii@chromium.org, Aug 18 2016

Owner: andyb...@chromium.org
agable@ isn't this a dup of  http://crbug.com/602906 ?

Comment 5 by aga...@chromium.org, Aug 18 2016

Mergedinto: 602906
Status: Duplicate (was: Assigned)
Yeah it is. I'll merge this into that, and update the summary and priority of that bug. This can't be a leave it for two months and then say "oh I wasn't making much progress and this seems tangled" issue, this is a launch blocker.

I'm not sure what's so hard about
if gerrit:
  check out ref
  gclient sync

as opposed to
if gerrit:
  check out ref
gclient runhooks
►

Sign in to add a comment