Issue metadata
Sign in to add a comment
|
Regression: Rubberband scrolling effect & text selecting are broken on latest Canary |
||||||||||||||||||||||
Issue descriptionVersion: 54.0.2832.0 canary (64-bit) OS: OSX 10.11.6 What steps will reproduce the problem? (1) Open a page (2) Scroll to the end or the beginning of the page (3) What is the expected output? A nice Rubberband scrolling effect. What do you see instead? The Ruberband scrolling effect is broken. Please use labels and text to provide additional information. This is a regression!
,
Aug 18 2016
From merged issue 638938 : Text selecting is also broken. Steps to reproduce the problem: 1. Open any web page (ideally one that can already scroll) 2. Attempt to scroll past the top of the page 3. Try selecting text or clicking on page elements What is the expected behavior? Scrolling should stop at the top of the page, and the scrollbar should stop moving. (On Mac, it should "bounce".) When interacting with page elements, clicking should interact with elements directly beneath the mouse. What went wrong? Scrolling does not bounce at the top of the page, the page jitters, and the scrollbar keeps shrinking. When interacting with page elements, clicking and dragging happens at a position offset from the mouse, as if the page had kept scrolling. Did this work before? Yes Yesterday, which was probably Chrome 53 Chrome version: 54.0.2832.0 Channel: canary OS Version: OS X 10.11.5 Flash Version: Shockwave Flash 23.0 r0 See video of the issue at https://youtu.be/jodkyeWOmNY I was unable to repro on Windows.
,
Aug 18 2016
Issue 639048 has been merged into this issue.
,
Aug 18 2016
This is the regression range: https://chromium.googlesource.com/chromium/src/+log/7f781f34f09fe2f3c5117f71de47e38d9bb59bad..806556451c84f03082ece3818862bbc22fd2727b May be this is the reason for the regression: https://codereview.chromium.org/2183403002 khushalsagar@: Can you please check if your patch is the culprit? Thanks in advance.
,
Aug 18 2016
Sure, I'll take a look. My change did touch a lot of code there.
,
Aug 18 2016
Fix up for review, https://codereview.chromium.org/2259083002/
,
Aug 19 2016
Issue 639187 has been merged into this issue.
,
Aug 19 2016
Issue 639369 has been merged into this issue.
,
Aug 19 2016
Patch in CQ.
,
Aug 19 2016
Issue 639338 has been merged into this issue.
,
Aug 19 2016
Issue 639283 has been merged into this issue.
,
Aug 19 2016
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f70f776fa8c14b5d684e39a85766dbef3f6e002a commit f70f776fa8c14b5d684e39a85766dbef3f6e002a Author: khushalsagar <khushalsagar@chromium.org> Date: Fri Aug 19 22:45:29 2016 cc: Correct elastic overscroll synchronization. The |elastic_overscroll_| was moved to LayerTree in this change (https://codereview.chromium.org/2183403002), and is being used for synchronization during commit, but it wasn't deleted from LayerTreeHost and was incorrectly used when building PropertyTrees and applying the delta during BeginMainFrame. BUG= 639046 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2259083002 Cr-Commit-Position: refs/heads/master@{#413272} [modify] https://crrev.com/f70f776fa8c14b5d684e39a85766dbef3f6e002a/cc/proto/layer_tree.proto [modify] https://crrev.com/f70f776fa8c14b5d684e39a85766dbef3f6e002a/cc/proto/layer_tree_host.proto [modify] https://crrev.com/f70f776fa8c14b5d684e39a85766dbef3f6e002a/cc/trees/layer_tree.cc [modify] https://crrev.com/f70f776fa8c14b5d684e39a85766dbef3f6e002a/cc/trees/layer_tree_host.cc [modify] https://crrev.com/f70f776fa8c14b5d684e39a85766dbef3f6e002a/cc/trees/layer_tree_host.h [modify] https://crrev.com/f70f776fa8c14b5d684e39a85766dbef3f6e002a/cc/trees/layer_tree_host_unittest_serialization.cc
,
Aug 19 2016
I just updated my Canary, but looks like this fix was not shipped yet... right? Because if it did, the issue is still happening for me... If I scroll down until the end of the page, the issue happens...
,
Aug 20 2016
This landed a couple of hours ago. Wouldn't be in the canary yet.
,
Aug 20 2016
Issue 639501 has been merged into this issue.
,
Aug 20 2016
,
Aug 20 2016
,
Aug 20 2016
I've manually verified that google.com appears to work correctly after scrolling with the CL in c#13. This should be fixed in the next canary.
,
Aug 20 2016
,
Aug 20 2016
,
Aug 20 2016
,
Aug 22 2016
Issue 639548 has been merged into this issue.
,
Aug 22 2016
Thanks guys... apparently every thing is back to normal... I still can not reproduce the issue after the new update this morning... I'll keep you guys posted if something else related to this happens... Thanks again...
,
Aug 22 2016
This item seems fixed for me as well (although there is a new unrelated bug which I will post in proper section if not posted already). Thanks for your efforts!
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e978686794916d58369484725af4a0b937bf5338 commit e978686794916d58369484725af4a0b937bf5338 Author: khushalsagar <khushalsagar@chromium.org> Date: Tue Aug 23 04:50:24 2016 cc: Add a test for the elastic overscroll synchronization. During each BeginMainFrame, we send the delta for the elastic overcroll to the main thread. This value is never mutated on the main thread, and is updated only from the impl thread. Add a test to verify this expectation and also ensure that the callbacks to the InputHandlerClient necessary for elastic overscroll synchronization are made. BUG= 639046 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2261383002 Cr-Commit-Position: refs/heads/master@{#413667} [modify] https://crrev.com/e978686794916d58369484725af4a0b937bf5338/cc/test/layer_tree_test.cc [modify] https://crrev.com/e978686794916d58369484725af4a0b937bf5338/cc/test/test_hooks.h [modify] https://crrev.com/e978686794916d58369484725af4a0b937bf5338/cc/trees/layer_tree_host.h [modify] https://crrev.com/e978686794916d58369484725af4a0b937bf5338/cc/trees/layer_tree_host_unittest_scroll.cc
,
Aug 23 2016
Rechecked this on chrome version 54.0.2837.0 on MAC 10.11.6 Retina Pro and fix is working as intended. Scrolling stops at the top / bottom of the page, and the scrollbar does not move. It just bounces. Selecting text also works fine after clicking while scrolling. Adding TE-verified labels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Aug 18 2016