Implement a spinner UI for ZTE |
||
Issue descriptionProposal: After issue 638431 is done, we could have a chrome command line switch to start in ZTE mode. When that switch is present, login screen should go directly to a spinner UI to wait for ZTE to finish. We could probably leverage the existing enrollment spinner UI, i.e. EnrollmentScreenHandler::ShowEnrollmentSpinnerScreen [1]. There are likely some work needs to be done to setup correct mode (e.g. call EnrollmentScreenHandler::Show to show enrollment screen first) to show this UI. [1]: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc?rcl=1471534131&l=175
,
Aug 18 2016
If you apply this CL, pass --enterprise-enable-zero-touch-enrollment to Chrome to enable the attestation-based registration.
,
Aug 25 2016
All the ZTE UX code is now in master.
,
Sep 16 2016
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd7115ab179b8909ad4d41bfc53cfa6f16263052 commit dd7115ab179b8909ad4d41bfc53cfa6f16263052 Author: kumarniranjan <kumarniranjan@google.com> Date: Fri Sep 16 22:04:34 2016 Show a spinner UI for zero-touch enrollment BUG= 639044 TEST=browser test CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2343183003 Cr-Commit-Position: refs/heads/master@{#419291} [modify] https://crrev.com/dd7115ab179b8909ad4d41bfc53cfa6f16263052/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/dd7115ab179b8909ad4d41bfc53cfa6f16263052/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/dd7115ab179b8909ad4d41bfc53cfa6f16263052/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.css [modify] https://crrev.com/dd7115ab179b8909ad4d41bfc53cfa6f16263052/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html [modify] https://crrev.com/dd7115ab179b8909ad4d41bfc53cfa6f16263052/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
,
Sep 16 2016
Great. In your unit test, you may want to check that after we call the show success step, the spinner is not visible anymore? That's really what you probably care to test there, not that the results show, though that's goodness too so I'd probably leave it in. |
||
►
Sign in to add a comment |
||
Comment 1 by drcrash@chromium.org
, Aug 18 2016