Issue metadata
Sign in to add a comment
|
"mash_browser_tests (with patch)" is flaky |
||||||||||||||||||||||||
Issue description"mash_browser_tests (with patch)" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 68 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9tYXNoX2Jyb3dzZXJfdGVzdHMgKHdpdGggcGF0Y2gpDA. This flaky test/step was previously tracked in issue 626869 .
,
Aug 18 2016
I believe Sadrul has been looking at this. I'm not sure that crash is relevant to the failure as last I looked it was in sysui, which doesn't effect the overall status of the test.
,
Aug 19 2016
That looks like a crash in mojo:ash, and ash crashing would explain the browser-test failing to complete too.
,
Aug 22 2016
I can repro the failure locally in non-component builds ... and, this is difficult to explain, but this seems to be an issue with tcmalloc. If I turn that off (e.g. is_asan = true, or use_allocator = 'none'), then the ash crashes go away, and mash_browser_tests stops becoming flaky.
,
Aug 22 2016
+wfh@ as tcmalloc owner: any advice on how I can debug possible issues with tcmalloc?
,
Aug 22 2016
,
Aug 22 2016
Yeah it's the same bug. Unfortunately it's fundamental flaw in mojo_runner that it can't work with tcmalloc in non-component builds. The workaround for now is to use component builds.
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d9ba42aa4635a02ddc20e9d155a055c76c510e5 commit 6d9ba42aa4635a02ddc20e9d155a055c76c510e5 Author: sadrul <sadrul@chromium.org> Date: Mon Aug 22 16:29:38 2016 ash/mus: Fix a crash during tear down. WindowManagerObserver can operate on the WMShell instance when the WindowTreeClient is destroyed (e.g. AcceleratorRegistrarImpl). So notify the observers before destroying the WMShell instance. BUG= 639039 Review-Url: https://codereview.chromium.org/2269473003 Cr-Commit-Position: refs/heads/master@{#413453} [modify] https://crrev.com/6d9ba42aa4635a02ddc20e9d155a055c76c510e5/ash/mus/window_manager.cc
,
Aug 22 2016
,
Aug 22 2016
I have filed issue 639882 to convert the FYI builder to do ozone + component builds.
,
Aug 22 2016
Ken is working on a fix for 594674. It doesn't sound too involved, should know soonish.
,
Aug 24 2016
,
Sep 10 2016
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6be9df9727afb4e827c24acc708abc1a5f49b92c commit 6be9df9727afb4e827c24acc708abc1a5f49b92c Author: sadrul <sadrul@chromium.org> Date: Mon Sep 12 22:24:19 2016 mash: Re-enable mash_browser_tests in ozone builder. The tests needed to be removed from the ozone builders because of the flak, but that has been addressed in crrev.com/415329 It should now be safe to turn the tests back on this builder. BUG= 639039 Review-Url: https://codereview.chromium.org/2257873005 Cr-Commit-Position: refs/heads/master@{#418077} [modify] https://crrev.com/6be9df9727afb4e827c24acc708abc1a5f49b92c/testing/buildbot/chromium.chromiumos.json
,
Feb 26 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by alex...@chromium.org
, Aug 18 2016Owner: sky@chromium.org
Status: Assigned (was: Untriaged)