New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 639013 link

Starred by 2 users
Status: Fixed
Owner:
zhongyi@chromium.org
Closed: Aug 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused histograms for QUIC

Project Member Reported by zhongyi@chromium.org, Aug 18 2016 
According to UMA histograms tracking, there're a few histograms we're no longer using. Remove those following histograms:
Net.QuicSession.6PacketsPatternsReceived*
Net.QuicSession.21CumulativePacketsReceived_Some21s_*
Net.QuicSession.21CumulativePacketsReceived_First21_*
Net.QuicSession.PacketReceived_IsNotAck_CONNECTION_*
Net.QuicSession.PacketReceived_IsAnAck_CONNECTION_*
Net.QuicSession.PacketReceived_Ack_CONNECTION_*
Net.QuicSession.PacketReceived_Nack_CONNECTION_*

Comment 1 by zhongyi@chromium.org, Aug 18 2016 

Issue 633445 has been merged into this issue.

Comment 2 by zhongyi@chromium.org, Aug 18 2016 

Issue 629394 has been merged into this issue.

Comment 3 by zhongyi@chromium.org, Aug 18 2016 

Issue 621755 has been merged into this issue.

Comment 4 by zhongyi@chromium.org, Aug 18 2016 

Issue 619809 has been merged into this issue.

Comment 5 by zhongyi@chromium.org, Aug 18 2016 

Issue 615923 has been merged into this issue.

Comment 6 by zhongyi@chromium.org, Aug 18 2016 

Issue 612228 has been merged into this issue.

Comment 7 by zhongyi@chromium.org, Aug 18 2016 

Issue 606601 has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b099e13e9cdd6d0380a4e915bc97f78436b73bbe

commit b099e13e9cdd6d0380a4e915bc97f78436b73bbe
Author: zhongyi <zhongyi@chromium.org>
Date: Thu Aug 18 23:59:59 2016

Remove histograms:
Net.QuicSession.6PacketsPatternsReceived*
Net.QuicSession.21CumulativePacketsReceived_Some21s_*
Net.QuicSession.21CumulativePacketsReceived_First21_*
Net.QuicSession.PacketReceived_IsNotAck_CONNECTION_*
Net.QuicSession.PacketReceived_IsAnAck_CONNECTION_*
Net.QuicSession.PacketReceived_Ack_CONNECTION_*
Net.QuicSession.PacketReceived_Nack_CONNECTION_*

BUG= 639013 

Review-Url: https://codereview.chromium.org/2255753003
Cr-Commit-Position: refs/heads/master@{#412976}

[modify] https://crrev.com/b099e13e9cdd6d0380a4e915bc97f78436b73bbe/net/quic/chromium/quic_connection_logger.cc
[modify] https://crrev.com/b099e13e9cdd6d0380a4e915bc97f78436b73bbe/net/quic/chromium/quic_connection_logger.h
[modify] https://crrev.com/b099e13e9cdd6d0380a4e915bc97f78436b73bbe/tools/metrics/histograms/histograms.xml

Comment 9 by zhongyi@chromium.org, Aug 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment