New issue
Advanced search Search tips

Issue 639010 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 639350
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 18 2016

Issue description

"ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTwsSBUZsYWtlIkRUb29sYmFyQWN0aW9uVmlld0ludGVyYWN0aXZlVUlUZXN0LlRlc3RDb250ZXh0TWVudU9uT3ZlcmZsb3dlZEFjdGlvbgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 637534 .
 
Owner: jonr...@chromium.org
Status: Assigned (was: Untriaged)
jonross@: looks like you already tried to fix the flakiness in this test in issue 557136.  Mind taking a look at whether this is the same or different failure?

The failure log is:
../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:281: Failure
Value of: browser()->tab_strip_model()->GetActiveWebContents()->GetVisibleURL()
  Actual: about:blank
Expected: GURL("https://www.google.com/")
Which is: https://www.google.com/

Labels: -Sheriff-Chromium
Cc: rdevlin....@chromium.org
+rdevlin.cronin@ FYI

Likely mine, though this flake is different. Will try it locally.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/643c38acd54e0e58d862e5d28a5674d713fe6c93

commit 643c38acd54e0e58d862e5d28a5674d713fe6c93
Author: jonross <jonross@chromium.org>
Date: Thu Aug 18 22:48:28 2016

Temporarily Disable ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction
The test if flaking, and I will not be able to address the fix today. Disabling in the interim

TBR=rdevlin.cronin@chromium.org
TEST=ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction
BUG= 639010 

Review-Url: https://codereview.chromium.org/2254963004
Cr-Commit-Position: refs/heads/master@{#412962}

[modify] https://crrev.com/643c38acd54e0e58d862e5d28a5674d713fe6c93/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Aug 19 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTwsSBUZsYWtlIkRUb29sYmFyQWN0aW9uVmlld0ludGVyYWN0aXZlVUlUZXN0LlRlc3RDb250ZXh0TWVudU9uT3ZlcmZsb3dlZEFjdGlvbgw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 6 by treib@chromium.org, Aug 22 2016

Labels: -Sheriff-Chromium
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd6568bdc044afe156d1bf4bb29cb3be213d615a

commit cd6568bdc044afe156d1bf4bb29cb3be213d615a
Author: jonross <jonross@chromium.org>
Date: Thu Aug 25 21:59:11 2016

Update Flaky ToolbarActionViewInteractiveUITests

Update ActivateOverflowedToolbarActionWithKeyboard to block on final keyboard
event, then clear the pending messages, before confirming the final state.

Update TestContextMenuOnOverflowedAction. Remove the concept of the context
menu callback, this is no longer needed with the menus not nesting message
loops. Instead of posting tasks to the message loop in order to continue the
test, they will be called directly. The message loop will still be ran until
idle in order to allow for the processing of UI events.

TEST=
ToolbarActionViewInteractiveUITests.ActivateOverflowedToolbarActionWithKeyboard,
ToolbarActionViewInteractiveUITests.TestContextMenuOnOverflowedAction
BUG= 638692 ,  639010 

Review-Url: https://codereview.chromium.org/2259353002
Cr-Commit-Position: refs/heads/master@{#414549}

[modify] https://crrev.com/cd6568bdc044afe156d1bf4bb29cb3be213d615a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/cd6568bdc044afe156d1bf4bb29cb3be213d615a/chrome/browser/ui/views/toolbar/toolbar_action_view.h
[modify] https://crrev.com/cd6568bdc044afe156d1bf4bb29cb3be213d615a/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Mergedinto: 639350
Status: Duplicate (was: Assigned)
The flakes I see for this are now the same timeouts as  issue 639350 . Merging in.

Sign in to add a comment