Bookmarks import from Firefox fails |
|||||||||||
Issue descriptionVersion: 54.0.2826.0 OS: Win7 With chrome://settings/importData (old settings UI since I can't find the import UI in new settings) when you import Firefox bookmarks (profile created by version 48), the following log appears: ERROR:connection.cc(1879)] places.sqlite sqlite error 1, errno 0: no such table: moz_bookmarks_roots, sql: SELECT root_name, folder_id FROM moz_bookmarks_roots and the bookmarks from Firefox aren't imported into Chrome. Looking at places.sqlite in the Firefox profile, there doesn't seem to be a moz_bookmarks_roots table in it. Also, https://hg.mozilla.org/mozilla-central/rev/db96206f80c8 indicates that this table has been removed.
,
Sep 15 2016
Issue 646728 has been merged into this issue.
,
Sep 16 2016
https://codereview.chromium.org/2296633002/ is under way to fix this and https://codereview.chromium.org/2349643002/ was also uploaded as an alternate solution. @isherman to decide which approach he prefers.
,
Sep 28 2016
FYI, anyone interested in working on this bug might also be interested in working on bug 592239 .
,
Oct 4 2016
I am also having this problem with Chrome 53.0.2785.143 and Firefox 49. An additional problem is that the user is not notified about the failure via the normal user interface. Instead there is a popup saying "Success!" and showing a big green check mark. The only sign of failure is that the expected imported bookmarks folder did not appear. The error message is only going to be seen by those running Chrome from a terminal and paying attention to output there. Others may waste time wondering where the imported bookmarks might be found in Chrome.
,
Oct 4 2016
Right, the big success notification is pretty bad. What's likely happening is that Firefox's bookmark database changed and Chrome no longer finds it (i.e. succeeds at seeing it's not there and thus importing nothing..!). As mentioned in #3, patches are under way to update FirefoxImporter::ImportBookmarks() in firefox_importer.cc to understand the latest format. +ewald FYI on poor UX for import failure shown as a big "success".
,
Oct 4 2016
Is there a more robust way we can handle this? Where we're not so tightly coupled/dependent on the structure of Firefox's bookmark database? E.g. it would be great in the future if Firefox changes their bookmark database again for us to at least display an appropriate error message of some kind to the user. +rpop desktop PM
,
Oct 5 2016
I guess what's hard to tell for a chrome reading the old format is whether there's truly nothing there or the format has moved sonewhwre else. Maybe a "nothing imported" UI would be interesting.
,
Oct 7 2016
Please make sure you check the HTML file import option from FF to Chrome also. This also does not work. About 20% of my bookmarks get imported and the rest don't.
,
Nov 22 2016
Still doesn't work. Give me one less reason to migrate from Firefox to Chrome.
,
Nov 23 2016
Patch for this bug is coming soon. I had a few problems with adding it.
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75d731d50a0595ffc184075ef4c084109a967752 commit 75d731d50a0595ffc184075ef4c084109a967752 Author: Ilya Sherman <isherman@chromium.org> Date: Thu Dec 01 00:14:53 2016 [Import] Add a test file for testing Firefox import code. The test file is too large to land via the CQ, so landing it manually. This is in support of [ https://codereview.chromium.org/2296633002 ]. BUG=638977 R=kszatan@opera.com TBR=kszatan@opera.com Review URL: https://codereview.chromium.org/2537143006 . Cr-Commit-Position: refs/heads/master@{#435492} [add] https://crrev.com/75d731d50a0595ffc184075ef4c084109a967752/chrome/test/data/import/firefox/48.0.2/places.sqlite
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a1ed3436f171ff0666d15d996ee033928c7dbf0 commit 8a1ed3436f171ff0666d15d996ee033928c7dbf0 Author: kszatan <kszatan@opera.com> Date: Mon Dec 05 11:31:57 2016 Fix Firefox bookmarks import. Firefox abandoned usage of the moz_bookmarks_roots table since v. 30 and removed the table in v. 31 in favor of storing relevant info in the 'guid' column of the moz_bookmarks table. BUG=638977 Review-Url: https://codereview.chromium.org/2296633002 Cr-Commit-Position: refs/heads/master@{#436262} [modify] https://crrev.com/8a1ed3436f171ff0666d15d996ee033928c7dbf0/chrome/browser/importer/firefox_importer_browsertest.cc [add] https://crrev.com/8a1ed3436f171ff0666d15d996ee033928c7dbf0/chrome/common/importer/mock_importer_bridge.cc [add] https://crrev.com/8a1ed3436f171ff0666d15d996ee033928c7dbf0/chrome/common/importer/mock_importer_bridge.h [modify] https://crrev.com/8a1ed3436f171ff0666d15d996ee033928c7dbf0/chrome/test/BUILD.gn [modify] https://crrev.com/8a1ed3436f171ff0666d15d996ee033928c7dbf0/chrome/utility/importer/firefox_importer.cc [modify] https://crrev.com/8a1ed3436f171ff0666d15d996ee033928c7dbf0/chrome/utility/importer/firefox_importer.h [modify] https://crrev.com/8a1ed3436f171ff0666d15d996ee033928c7dbf0/chrome/utility/importer/firefox_importer_unittest.cc
,
Jan 22 2017
Sure would like to try Chrome, but this is getting ridiculous. This bug has been open since August
,
Jan 22 2017
Fixed in Chrome 57 (currently Chrome Beta) according to the above commits.
,
Feb 2 2017
Just tried it with Canary (58.0.3000.0), still doesn't work.
,
Feb 11 2017
Still not working. Jeez, how hard can this be?
,
Feb 12 2017
Bunch of family members all use firefox. They have indicated they are going to stop new browser development so all their users will probably switch to something, even Edge is they can't import bookmarks. Gotta fix this!
,
Feb 12 2017
This issue isn't a big deal for me because I can export from Firefox to HTML and then import that into Chrome. The only disadvantages are that it's more work and it doesn't import favicons. In Firefox in the Bookmark menu, select Show All Bookmarks (Ctrl+Shift+B). Click on Import and Backup near the top, and then select Export Bookmarks to HTML. Then in Chrome, in the Bookmarks sub-menu select Bookmark Manager (Ctrl+Shift+O). Click on Organize at the top of the right pane and select Import bookmarks from HTML file.
,
Feb 13 2017
Thank you Boris. I had forgot about the exporting from Firefox as the option did not seem readily visible to me. The Ctrl+Shift+B helped and now all is good. Thx again.
,
Feb 15 2017
You're welcome! This worked for me in Chrome 58.0.3012.1 canary SyzyASan importing bookmarks from Firefox Nightly 54.0a1 (2017-02-14) (64-bit).
,
Oct 20 2017
Same problem with Windows 10 although I had previously had no problem importing Firefox bookmarks into Chrome with an older computer running on Windows 7. Chrome claims bookmarks are imported, but they are not.
,
Dec 1 2017
same problem with me w10 and latest firefox and google chrome will not import all the settings and bookmarks I did work around for bookmarks by exporting to html and importing but no passwords etc other important data :-(
,
Dec 1 2017
Ilya could you take a look? If this has regressed I would like to fix it for 65.
,
Dec 1 2017
Sorry, I don't have bandwidth to work on importer bugs currently. I'd be happy to help with guidance and/or code reviews, but won't be able to drive the fix.
,
Dec 2 2017
Issue 774849 has been merged into this issue.
,
Dec 2 2017
,
Dec 4 2017
,
Dec 7 2017
[Mac triage] shrike@/groby@: This seems like a real issue for people switching to Chrome, can you find someone to look into this?
,
Dec 8 2017
I've just created a review for CL that should fix this issue: https://chromium-review.googlesource.com/c/chromium/src/+/817435
,
Dec 8 2017
Issue 792831 has been merged into this issue.
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab49b2a1b1d495b62170e2c37c6b39b9d85c185d commit ab49b2a1b1d495b62170e2c37c6b39b9d85c185d Author: Tomasz Moniuszko <tmoniuszko@opera.com> Date: Mon Dec 18 12:34:39 2017 Fix bookmark importing from Firefox Bug: 638977 Change-Id: I3336f64fc9497417831afa24f8403a63b77797bb Reviewed-on: https://chromium-review.googlesource.com/817435 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524685} [add] https://crrev.com/ab49b2a1b1d495b62170e2c37c6b39b9d85c185d/chrome/test/data/import/firefox/57.0.1/favicons.sqlite [add] https://crrev.com/ab49b2a1b1d495b62170e2c37c6b39b9d85c185d/chrome/test/data/import/firefox/57.0.1/places.sqlite [modify] https://crrev.com/ab49b2a1b1d495b62170e2c37c6b39b9d85c185d/chrome/utility/importer/firefox_importer.cc [modify] https://crrev.com/ab49b2a1b1d495b62170e2c37c6b39b9d85c185d/chrome/utility/importer/firefox_importer.h [modify] https://crrev.com/ab49b2a1b1d495b62170e2c37c6b39b9d85c185d/chrome/utility/importer/firefox_importer_unittest.cc
,
Feb 20 2018
Adding conops hotlist for tracking.
,
Mar 1 2018
A user reported that all Chrome 64, 65 and 66 cannot import Firefox successfully. If the user can provide more debugging information on this, feel free to jump in to the thread. https://productforums.google.com/forum/#!topic/chrome/pg2zS5E4oM8
,
Mar 13 2018
Will this ever get fixed? I won't switch over till I can import cookies, passwords etc., and from the looks of it this has been unresolved for more than a year. Should I lose hope or is there a chance for it to get fixed reasonably soon? |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by isherman@chromium.org
, Aug 18 2016Status: Available (was: Untriaged)