New issue
Advanced search Search tips

Issue 638963 link

Starred by 1 user
Status: Fixed
Owner:
melandory@chromium.org
Closed: Nov 2017
Cc:
sabineb@chromium.org
zea@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Tracking bug for the migration if the sync passwords schema.

Project Member Reported by melandory@chromium.org, Aug 18 2016 
Store Chrome passwords data in Sync servers in a format that optimizes looking up the password for a specific URL.


This is the tracking bug for the client side changes, which include:
* introducing changes to the protocol
* populating newly introduced field with data
* clearing data when nessary, e.g. when user turns on encryption with a custom passphrase.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c

commit 5c441aa82555fcc384e3e31fb90bdfb6888d4a0c
Author: melandory <melandory@chromium.org>
Date: Tue Aug 30 06:09:10 2016

Make PassphraseType a "enum class" instead of "enum".

Make PassphraseType a "enum class" instead of "enum" which enable
forward declaration.

BUG= 638963 

Review-Url: https://codereview.chromium.org/2279713002
Cr-Commit-Position: refs/heads/master@{#415202}

[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/core/sync_encryption_handler.h
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/core_impl/js_sync_encryption_handler_observer_unittest.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/core_impl/sync_encryption_handler_impl.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/core_impl/sync_encryption_handler_impl_unittest.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/core_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/driver/glue/sync_backend_host_mock.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/engine/sync_status.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/engine/sync_string_conversions.cc
[modify] https://crrev.com/5c441aa82555fcc384e3e31fb90bdfb6888d4a0c/components/sync/test/fake_sync_encryption_handler.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d67cd89ff721b10093918374e35c892986fa135

commit 8d67cd89ff721b10093918374e35c892986fa135
Author: melandory <melandory@chromium.org>
Date: Tue Aug 30 21:10:03 2016

Move definition of PasswordType enum to a separate header.

BUG= 638963 

Review-Url: https://codereview.chromium.org/2279753003
Cr-Commit-Position: refs/heads/master@{#415425}

[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/BUILD.gn
[add] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/base/passphrase_type.cc
[add] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/base/passphrase_type.h
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/core/sync_encryption_handler.h
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/core_impl/js_sync_encryption_handler_observer_unittest.cc
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/core_impl/sync_encryption_handler_impl.cc
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/engine/sync_status.h
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/engine/sync_string_conversions.cc
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/engine/sync_string_conversions.h
[modify] https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135/components/sync/test/fake_sync_encryption_handler.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71d9b4ade725d81ff9a8a85e68aeeab9bfb79f4a

commit 71d9b4ade725d81ff9a8a85e68aeeab9bfb79f4a
Author: melandory <melandory@chromium.org>
Date: Wed Aug 31 18:48:15 2016

Supplimentary identifier for passwords specific.

Adds new message field to the Password Scpecific proto and implements clearing of the data in case custom passphrase is turned on.
The population of the metadata is not implemented in this CL.

BUG= 638963 

Review-Url: https://codereview.chromium.org/2278333002
Cr-Commit-Position: refs/heads/master@{#415699}

[modify] https://crrev.com/71d9b4ade725d81ff9a8a85e68aeeab9bfb79f4a/components/sync/core_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/71d9b4ade725d81ff9a8a85e68aeeab9bfb79f4a/components/sync/protocol/password_specifics.proto
[modify] https://crrev.com/71d9b4ade725d81ff9a8a85e68aeeab9bfb79f4a/components/sync/protocol/proto_value_conversions.cc
[modify] https://crrev.com/71d9b4ade725d81ff9a8a85e68aeeab9bfb79f4a/components/sync/syncable/nigori_util.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72e34aa0b649fb40e03bc171da020bb4e9ccdef6

commit 72e34aa0b649fb40e03bc171da020bb4e9ccdef6
Author: melandory <melandory@chromium.org>
Date: Tue Oct 25 14:03:14 2016

Fill the unencrypted metadata field in password specifics.

Fills the unencrypted metadata field when writing to the password entity is triggered, which should happen on every start up. This way it allows us to bootstrap the over wise empty field.

* Field should stay empty for custom passphrase users.
* The feature is guarded by the experiment, so the field should stay empty if experiment is disabled.
* The entity shouldn't be marked unsynced unless the change to the field has happened.

BUG= 638963 

Review-Url: https://codereview.chromium.org/2294913009
Cr-Commit-Position: refs/heads/master@{#427336}

[modify] https://crrev.com/72e34aa0b649fb40e03bc171da020bb4e9ccdef6/components/sync/BUILD.gn
[add] https://crrev.com/72e34aa0b649fb40e03bc171da020bb4e9ccdef6/components/sync/base/sync_features.cc
[add] https://crrev.com/72e34aa0b649fb40e03bc171da020bb4e9ccdef6/components/sync/base/sync_features.h
[modify] https://crrev.com/72e34aa0b649fb40e03bc171da020bb4e9ccdef6/components/sync/engine_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/72e34aa0b649fb40e03bc171da020bb4e9ccdef6/components/sync/syncable/base_transaction.cc
[modify] https://crrev.com/72e34aa0b649fb40e03bc171da020bb4e9ccdef6/components/sync/syncable/base_transaction.h
[modify] https://crrev.com/72e34aa0b649fb40e03bc171da020bb4e9ccdef6/components/sync/syncable/write_node.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71a8d2bf8925027fdb6a80839542be27a2afdf83

commit 71a8d2bf8925027fdb6a80839542be27a2afdf83
Author: melandory <melandory@chromium.org>
Date: Wed Feb 08 17:07:02 2017

Enable PasswordMetadataFilling feature on bots.

BUG= 638963 

Review-Url: https://codereview.chromium.org/2687663002
Cr-Commit-Position: refs/heads/master@{#449019}

[modify] https://crrev.com/71a8d2bf8925027fdb6a80839542be27a2afdf83/testing/variations/fieldtrial_testing_config.json

Comment 7 by vabr@chromium.org, May 2 2017

Components: UI>Browser>Passwords

Comment 8 by vabr@chromium.org, May 2 2017

Labels: -tracking_work Type-Task

Comment 10 by melandory@chromium.org, Nov 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment