New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638962 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 642983



Sign in to add a comment

Downloading page crashes in incognito

Project Member Reported by twelling...@chromium.org, Aug 18 2016

Issue description

signal 11 (SIGSEGV), code 1, fault addr 0x14 in tid 32645 (oid.apps.chrome)
pid: 32645, tid: 32645, name: oid.apps.chrome  >>> com.google.android.apps.chrome <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x14
     r0 00000014  r1 00000000  r2 00000020  r3 ffe18100
     r4 00000014  r5 00000010  r6 ffe182d0  r7 12ea69b8
     r8 d052b5cc  r9 e9b05400  sl 12ea69b8  fp 7f0e0320
     ip c89c8898  sp ffe18110  lr c8963a05  pc eb383606

Stack Trace:
  RELADDR   FUNCTION                                                                                      FILE:LINE
  00047606  pthread_mutex_lock+1                                                                          /system/lib/libc.so
  000b1a01  Lock                                                                                          /work/clankium/src/base/synchronization/lock_impl_posix.cc:64
  v------>  Acquire                                                                                       /work/clankium/src/base/synchronization/lock.h:45
  v------>  AutoLock                                                                                      /work/clankium/src/base/synchronization/lock.h:115
  000c3691  CalledOnValidThread                                                                           /work/clankium/src/base/threading/thread_checker_impl.cc:19
  000b0615  GetUserData                                                                                   /work/clankium/src/base/supports_user_data.cc:17
  00a26131  FromOfflinePageModel                                                                          /work/clankium/src/components/offline_pages/downloads/download_ui_adapter.cc:41
  v------>  Init                                                                                          /work/clankium/src/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc:204
  0048f765  Java_org_chromium_chrome_browser_offlinepages_downloads_OfflinePageDownloadBridge_nativeInit  /work/clankium/src/out-gn/Debug/gen/chrome/browser/jni_headers/chrome/jni/OfflinePageDownloadBridge_jni.h:45
  0024ae9d  offset 0x52d000                                                                               /data/data/com.google.android.apps.chrome/incremental-install-files/optimized-dexes/chrome.android.chrome_java.dex.dex




The page is getting initialized in ChromeActivity.java:1547:
final OfflinePageDownloadBridge bridge =
    new OfflinePageDownloadBridge(currentTab.getProfile());
bridge.startDownload(currentTab);


This also affects ToolbarTablet.java:https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java?dr=CSs&q=toolbartablet&sq=package:chromium&l=79

 
That's correct. Offline page model is not enabled in incognito, and just got the decision to make it so. It would be useful to make the code more defensive thou.
The button to download pages is currently disabled in the UI in incognito, so we aren't crashing. I enabled it to grab the stack trace.
Great idea, and thanks!
Tested in M54-54.0.2840.8 build and not see "Download" button in incognito mode
kravula@ - it should be disabled on phones and removed entirely on tablets. What type of device were you testing on?
Cc: dim...@chromium.org fgor...@chromium.org
Labels: -Restrict-View-Google -Pri-1 M-55 Pri-2
Owner: ----
Status: Available (was: Assigned)
This is disabled (bypassed) in M54 and should be a work item for M55.
Blockedon: 642983

Comment 8 by dim...@chromium.org, Oct 12 2016

Labels: -M-55 M-56 Type-Bug
Moved to M56 since it is a new M55.

Comment 9 by dim...@chromium.org, Oct 19 2016

Owner: dah...@chromium.org
Status: Assigned (was: Available)
dahlke@: assigning to you to finalize design, fgorski@ would be working on implementation.
Labels: -M-56 M-58
Status: (was: Assigned)
Closing fixed since the crash does not happen (functionality disabled). We should have separate Incognito launch bug.
Status: Fixed

Sign in to add a comment