New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638944 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

third_party/zlib/mozzconf.h defines Byte as MOZ_Z_Byte

Project Member Reported by gsennton@chromium.org, Aug 18 2016

Issue description

third_party/zlib/mozzconf.h defines Byte as MOZ_Z_Byte and because of this including jni-code (<jni.h>) causes a compilation error (because the word Byte used in jni.h is replaced with MOZ_Z_Byte).


Example compilation error when including <jni.h> in base/message_loop/message_loop.h:


In file included from ../../base/message_loop/message_loop.h:41:0,
                 from ../../third_party/zlib/google/zip_reader.cc:13:
../../third_party/android_tools/ndk/platforms/android-16/arch-arm/usr/include/jni.h: In member function 'jbyte _JNIEnv::CallMOZ_Z_ByteMethod(jobject, jmethodID, ...)':
../../third_party/android_tools/ndk/platforms/android-16/arch-arm/usr/include/jni.h:638:5: error: 'const struct JNINativeInterface' has no member named 'CallMOZ_Z_ByteMethodV'
     CALL_TYPE(jbyte, Byte)
     ^


(this is something I tried to do locally, and I've now worked around it. But it still seems bad to rename something as generic as the word "Byte" :/).
 
Labels: OS-Android
The original problem isn't really an android-only problem - we could just as well have used the word "Byte" in any other OS and having that be overwritten to MOZ_Z_Byte.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 21 2017

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment