<dialog>.close() should never throw per the current spec |
|||||||
Issue description
,
Aug 26 2016
,
Aug 26 2016
,
Aug 28 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 29 2017
http://wpt.fyi/html/semantics/interactive-elements/the-dialog-element/dialog-close.html Looks like other browsers still haven't shipped <dialog>. In Firefox, there's a pref in about:config dom.dialog_element.enabled, and then it passes the test. It would be good to have interop on this when Firefox ships. Gecko bug for <dialog>: https://bugzilla.mozilla.org/show_bug.cgi?id=840640
,
Sep 4 2017
We have a failure because of this: http://wpt.fyi/html/semantics/interactive-elements/the-dialog-element/dialog-close.html
,
Sep 4 2017
Attempting fix i https://chromium-review.googlesource.com/648980
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf commit ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf Author: Philip Jägenstedt <foolip@chromium.org> Date: Tue Sep 05 07:56:57 2017 Make dialog.close() a no-op when already closed This matches the standard: https://html.spec.whatwg.org/multipage/interactive-elements.html#close-the-dialog https://crbug.com/761790 was filed about the fact that we appear to have a much better test suite for <dialog> than exists in web-platform-tests. Drive-by: resolve the FIXME about default argument value for close(), and remove the stale FIXME that is no longer correct. Bug: 638943 Change-Id: I82743f7d725ed85c42c9e349b669f098b5a3e10d Reviewed-on: https://chromium-review.googlesource.com/648980 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#499581} [delete] https://crrev.com/2e441c8f0b0aa36b0eb7a6f05a0e498c5a1c04ac/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt [modify] https://crrev.com/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf/third_party/WebKit/LayoutTests/html/dialog/dialog-open-expected.txt [modify] https://crrev.com/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf/third_party/WebKit/LayoutTests/html/dialog/dialog-open.html [modify] https://crrev.com/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf/third_party/WebKit/LayoutTests/html/dialog/dialog-return-value-expected.txt [modify] https://crrev.com/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf/third_party/WebKit/LayoutTests/html/dialog/dialog-return-value.html [modify] https://crrev.com/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp [modify] https://crrev.com/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf/third_party/WebKit/Source/core/html/HTMLDialogElement.h [modify] https://crrev.com/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf/third_party/WebKit/Source/core/html/HTMLDialogElement.idl [modify] https://crrev.com/ad699f89ba8bc3c0bbbc61c122df8c632aa3a5cf/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
,
Sep 5 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ajha@chromium.org
, Aug 25 2016