New issue
Advanced search Search tips

Issue 638935 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

LibFuzzer builds are broken due to recent change related to ffmpeg_branding

Project Member Reported by mmoroz@chromium.org, Aug 18 2016

Issue description

LibFuzzer builds are broken on all platforms:

https://build.chromium.org/p/chromium.fyi/buildslaves/slave43-c1

https://build.chromium.org/p/chromium.fyi/buildslaves/vm113-m1


Looks like https://codereview.chromium.org/1569053002 is the issue.

Could you please revert the CL or land a fix? It's important to have fresh builds of LibFuzzer-based fuzzers to test security and stability of Chromium.


 
Done https://codereview.chromium.org/2260523002/ but it requires someone to stamp it.

Comment 2 by aarya@google.com, Aug 18 2016

Status: Fixed (was: Untriaged)
Revert Cl landed
Owner: mmoroz@chromium.org
Status: Assigned (was: Fixed)
Not fixed, this means fuzzer builds aren't building correctly. They need to set ffmpeg_branding="ChromeOS" && is_proprietary_Codecs=true for Linux.

Comment 4 by aarya@google.com, Aug 19 2016

Cc: dpranke@chromium.org
https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=0&l=2091 Why do we have that then ? What if we don't want ChromeOS stuff ?

    'chrome_with_codecs': {
      'mixins': ['ffmpeg_branding_chrome', 'proprietary_codecs'],
    },
Labels: -Pri-0 Pri-1
ffmpeg_branding=Chrome is fine too, but the recipe seems to not be working if that assert is being triggered.
Yeah, these are misconfigured, https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=0&l=1317 they need to be using chrome_with_codecs and not just propertiary_codecs in the mixin -- will send a CL tomorrow or if someone wants to fix before then, feel free.
Hi Dale, I will wait that you land the change you mentioned and then let me know when I can re-commit https://codereview.chromium.org/1569053002/.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ded04b8261c21b7a0a968c5f3cdd404c27e4131e

commit ded04b8261c21b7a0a968c5f3cdd404c27e4131e
Author: dalecurtis <dalecurtis@chromium.org>
Date: Fri Aug 19 22:00:28 2016

Fix libfuzzer configurations to actually use proprietary codecs.

These configurations were configuring proprietary codecs without
actually setting ffmpeg up for such support, so they were not
testing everything they could be.

Note: There was a duplicate config for gn_release_libfuzzer_asan,
so I just changed it to be mac only (which doesn't have a ChromeOS
codec configuration for ffmpeg).

The choice of chromeos for the linux variants allows more coverage
of codecs we ship across the breadth of linux based platforms.

BUG= 571417 ,  638935 
TEST=mb_unittest

Review-Url: https://codereview.chromium.org/2260893002
Cr-Commit-Position: refs/heads/master@{#413260}

[modify] https://crrev.com/ded04b8261c21b7a0a968c5f3cdd404c27e4131e/tools/mb/mb_config.pyl

Cc: -dalecur...@chromium.org mmoroz@chromium.org
Owner: dalecur...@chromium.org
Status: Fixed (was: Assigned)
Should be fixed now -- going to revert the revert https://codereview.chromium.org/2260523002/
Thanks a lot!
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca2d62e8ed9d068f34c0241d5b748c51bc0b2b5

commit eca2d62e8ed9d068f34c0241d5b748c51bc0b2b5
Author: mmoroz <mmoroz@chromium.org>
Date: Wed Aug 31 15:25:39 2016

Do not use |target_os="chromeos"| for libFuzzer and AFL build configurations.

Usage of 'chromeos_with_codecs' mixin, that adds target_os="chromeos",
leads to loosing of 36 active and 3 disabled fuzzers.
This CL doesn't lead to loosing of any fuzzers and also brings
back those 36 and 3 fuzzers.

R=aizatsky@chromium.org, dalecurtis@chromium.org, dpranke@chromium.org, inferno@chromium.org
BUG= 638935 

Review-Url: https://codereview.chromium.org/2291123006
Cr-Commit-Position: refs/heads/master@{#415638}

[modify] https://crrev.com/eca2d62e8ed9d068f34c0241d5b748c51bc0b2b5/tools/mb/mb_config.pyl

Sign in to add a comment