Regression: [MD] Setting page is not seen properly after clicking on close icon of search box.
Reported by
jshan...@etouch.net,
Aug 18 2016
|
|||
Issue descriptionChrome Version: 54.0.2832.0 (Official Build) (64-bit) Revision 6c7eba987dc174e1522212efec1676619aa26a5a-refs/heads/master@{#412743} 32/64 Bit. OS: Mac (10.10.5)(10.11.5), Windows (7,8,8.1,10), Linux(14.04 LTS) Steps: 1. Launch Chrome, navigate to chrome://md-settings and click on Site settings under Advance. 2. Type some text like 'person' in search box and click on close icon of search box. 3. Observe. Actual: Setting page is not seen properly after clicking on close icon of search box i.e content above Advance is not seen. Expected: Setting page should be seen properly after clicking on close icon of search box i.e content above Advance should be seen. This is a regression issue broken in M-54, below is bisect info. Good build: 54.0.2820.0 Bad build: 54.0.2821.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/9899e4981f012aff59656a0ded9bde8b7fb626b0..b4b7c8e0dd470d54346abab2446b497ae34bf3c9?pretty=fuller&n=100 Suspecting: r410136 ? Please help to re-assign if your change is not the cause for this issue.
,
Sep 16 2016
,
Sep 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fb3dc8814cdc4f02ffe147f0d9caf34827a2175 commit 6fb3dc8814cdc4f02ffe147f0d9caf34827a2175 Author: dpapad <dpapad@chromium.org> Date: Tue Sep 20 18:35:12 2016 MD Settings: After clearing search, always display the "basic" page. If the search was initiated by a subpage whose parent was the "advanced" page (for example Site Settings), after clearing the search results, only the contents of the "advanced" page were shown. - Replacing previousSearchPages_ with a single inSearchMode_ boolean. - Determining whether the "advanced" page should be restored by using the existing advancedToggleExpanded_ boolean. Other parts of settings_main.js already treat that boolean as the source of truth. BUG= 638915 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2343153005 Cr-Commit-Position: refs/heads/master@{#419823} [modify] https://crrev.com/6fb3dc8814cdc4f02ffe147f0d9caf34827a2175/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/6fb3dc8814cdc4f02ffe147f0d9caf34827a2175/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/6fb3dc8814cdc4f02ffe147f0d9caf34827a2175/chrome/test/data/webui/settings/settings_main_test.js
,
Sep 20 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Sep 16 2016The problem occurs only when search is initiated from a subpage that resides under "Advanced". Specifically, when such a subpage is shown onSubpageExpanded_() executes [1], which assigns {about: false, basic: false, advanced: true} to the showPages_ property. When search is initiated, it remembers the value of showPages_, and restores it after seach is cleared, but {about: false, basic: false, advanced: true} is not a good state to return to. Instead, the "basic" page should always be shown. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_main/settings_main.js?q=settings_main.js&l=166