New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638869 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Inheritance propagation in shadow dom v0 trees causes full subtree recalcs

Reported by r...@opera.com, Aug 18 2016

Issue description

We currently trigger a subtree recalc for inheritance propagation through InsertionPoint::willRecalcStyle.

 
inherit.html
522 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfe6cf582c76a362871d93821a25ee5af7037cc1

commit dfe6cf582c76a362871d93821a25ee5af7037cc1
Author: rune <rune@opera.com>
Date: Thu Aug 25 10:56:19 2016

Use LocalStyleChange for insertion point inheritance propagation.

For shadow dom v0, we used a SubtreeStyleChange for propagating
inherited style changes through insertion points to distributed nodes.
LocalStyleChange should suffice. We already use LocalStyleChange in the
HTMLSlotElement case.

We still need to use SubtreeStyleChange where we have a
SubtreeStyleChange/Force from further up the tree like:

<host>
  <:shadow-root>
    <style>.a::content * { background: green }</style>
    <div id="a">
      <content></content>
    </div>
  </:shadow-root>
  <div>Green when #a gets class a.</div>
</host>

R=kochi@chromium.org
BUG= 638869 

Review-Url: https://codereview.chromium.org/2258793003
Cr-Commit-Position: refs/heads/master@{#414386}

[add] https://crrev.com/dfe6cf582c76a362871d93821a25ee5af7037cc1/third_party/WebKit/LayoutTests/fast/css/invalidation/inherit-through-insertion-point-v0.html
[modify] https://crrev.com/dfe6cf582c76a362871d93821a25ee5af7037cc1/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp

Comment 2 by r...@opera.com, Aug 25 2016

Status: Fixed (was: Started)

Sign in to add a comment