New issue
Advanced search Search tips

Issue 638840 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: "Agree" button does not work in ARC opt-in dialog

Project Member Reported by nya@chromium.org, Aug 18 2016

Issue description

Version: ToT Chrome (r412753)
OS: Chrome OS

In ARC opt-in dialog, "agree" button does not work, so I can't enable ARC.

The suspect is this change:
https://codereview.chromium.org/2254673003/

 

Comment 1 by yawano@chromium.org, Aug 18 2016

Status: Fixed (was: Assigned)
I've reverted the suspected CL. Mark this as fixed for now.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e2b1930480538185b0cef473949b586d96f4da2

commit 1e2b1930480538185b0cef473949b586d96f4da2
Author: yawano <yawano@chromium.org>
Date: Thu Aug 18 17:53:48 2016

Reland: arc: avoid checkbox AutomationNode issue

The original CL has caused  https://crbug.com/638840 .
This CL includes the fix to the issue in addition to the original CL.

BUG= 638501 , 638840 
BUG=b/30906810
TEST=tested as described in the issues.

Original description:
arc: avoid checkbox AutomationNode issue

Avoid checkbox AutomationNode issue  https://crbug.com/638498 

BUG= 638501 
BUG=b/30906810
TEST=tested as described in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f
Cr-Commit-Position: refs/heads/master@{#412740}

patch from issue 2254673003 at patchset 1 (http://crrev.com/2254673003#ps1)

Review-Url: https://codereview.chromium.org/2259713003
Cr-Commit-Position: refs/heads/master@{#412887}

[modify] https://crrev.com/1e2b1930480538185b0cef473949b586d96f4da2/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/1e2b1930480538185b0cef473949b586d96f4da2/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/1e2b1930480538185b0cef473949b586d96f4da2/chrome/browser/resources/chromeos/arc_support/main.html

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29cbc1a0cd1822aef185b482a41ddd23e52251ca

commit 29cbc1a0cd1822aef185b482a41ddd23e52251ca
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Aug 23 13:41:01 2016

Reland: arc: avoid checkbox AutomationNode issue

The original CL has caused  https://crbug.com/638840 .
This CL includes the fix to the issue in addition to the original CL.

BUG= 638501 , 638840 
BUG=b/30906810
TEST=tested as described in the issues.
TBR=xiyuan@chromium.org

Original description:
arc: avoid checkbox AutomationNode issue

Avoid checkbox AutomationNode issue  https://crbug.com/638498 

BUG= 638501 
BUG=b/30906810
TEST=tested as described in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f
Cr-Commit-Position: refs/heads/master@{#412740}

patch from issue 2254673003 at patchset 1 (http://crrev.com/2254673003#ps1)

Review-Url: https://codereview.chromium.org/2259713003
Cr-Commit-Position: refs/heads/master@{#412887}
(cherry picked from commit 1e2b1930480538185b0cef473949b586d96f4da2)

Review URL: https://codereview.chromium.org/2274543002 .

Cr-Commit-Position: refs/branch-heads/2785@{#723}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/29cbc1a0cd1822aef185b482a41ddd23e52251ca/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/29cbc1a0cd1822aef185b482a41ddd23e52251ca/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/29cbc1a0cd1822aef185b482a41ddd23e52251ca/chrome/browser/resources/chromeos/arc_support/main.html

Labels: VerifyIn-54
Status: Verified (was: Fixed)

Sign in to add a comment