New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638839 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Merge createCrossThreadTask to ExecutionContextTask.h

Project Member Reported by yuryu@chromium.org, Aug 18 2016

Issue description

createSameThreadTask is in ExecutionContextTask.h but createCrossThreadTask in another file, whose implementation is only 4 lines. Merging this function into ExecutionContextTask.h.
 

Comment 1 by yuryu@chromium.org, Aug 25 2016

Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84f5959aa09e9841e5aea9993247b46b42a60d9a

commit 84f5959aa09e9841e5aea9993247b46b42a60d9a
Author: yuryu <yuryu@chromium.org>
Date: Thu Aug 25 11:07:04 2016

Move createCrossThreadTask to ExecutionContextTask.h

Move createCrossThreadTask to ExecutionContextTask.h so that
both same thread and cross thread versions of createTask are in the
same header file.
Currently createCrossThreadTask is in CrossThreadTask.h,
but the implementation is a few lines of code, so merging it to
ExecutionContextTask.h and removing CrossThreadTask.h.

BUG= 638839 

Review-Url: https://codereview.chromium.org/2264543002
Cr-Commit-Position: refs/heads/master@{#414390}

[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/core.gypi
[delete] https://crrev.com/efc343f3e590013c880525c0d934f1322dc5438d/third_party/WebKit/Source/core/dom/CrossThreadTask.h
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/dom/ExecutionContextTask.h
[rename] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/dom/ExecutionContextTaskTest.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/84f5959aa09e9841e5aea9993247b46b42a60d9a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Sign in to add a comment