Issue metadata
Sign in to add a comment
|
Regression : Weird flickering of history list is seen in the background in chrome://history page.
Reported by
mni...@etouch.net,
Aug 18 2016
|
||||||||||||||||||||||||
Issue descriptionVersion : 54.0.2831.0 4bb92a6392a2f8bdc5c6c1319690800748870f1c-refs/heads/master@{#412405} (64-bit) OS : Mac OS X(10.11.4,10.11.5,10.10.5) What steps will reproduce the problem? 1) Launch chrome and navigate to chrome://history/ 2) Now select any item from history list(Mark it as checked) and click on 'Delete' button on top RHS of page and observe the history list in the background Actual : Weird flickering of history list is seen in the background after clicking 'Delete' button Expected : Weird flickering of history list should not be seen in the background after clicking 'Delete' button This is a regression issue broken in 'M-54' and below is the manual regression and Narrow bisect info: Good build : 54.0.2830.0 Bad build : 54.0.2831.0 Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/2c640ac2482f42824fb8f7de6fdf1d8679a2e2b9..ab7b497976d171ee4d7ceac09e994002de38407b?pretty=fuller&n=100 Suspecting : r412139 ? from Narrow bisect @sashab : Could you please help to reassign if your change is not the cause for this change. Note : Issue is not seen on Linux and Windows OS
,
Aug 18 2016
,
Aug 18 2016
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Aug 18 2016
I'd be surprised if it is ResizeObserver, but I'll take a look.
,
Aug 18 2016
Bisected it. The cause is 777aa9, reassigning.
,
Aug 18 2016
Looking at the cause of the bug. There is something funny going on with Polymer. I am experimenting with pressing on Cancel and Delete buttons, and both of them hide history panel when pressed. Sometimes, they make it blink too. Underlying bug might have always been there, and this checkin just made it become more obvious.
,
Aug 18 2016
Unexpected finding:
clicking on the Cancel button starts Polymer's ripple animation. The start of ripple animation makes history list disappear.
Exact line of code that makes history list disappear is:
paper-ripple-extracted.js:223
this.wave.style.webkitTransform = 'scale(' + scale + ',' + scale + ')';
At this point, wave is just a div, far away from history div. There is no reason for its transform to affect history list.
The only way I can imagine them being connected is through some weird animation event chain....
,
Aug 18 2016
Correction: this line makes history list disappear:
this.waveContainer.style.transform = 'translate3d(' + dx + 'px, ' + dy + 'px, 0)';
,
Aug 18 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sashab@chromium.org
, Aug 18 2016