git cl owners suggestions are bad |
||||||
Issue descriptionTo reproduce: 1) Create a CL 2) Run git cl owners Expected behaviour: git cl owners picks an owner that is 1) Not marked "ooo", "away", or "slow" 2) Specific 3) Known to review code in this area 4) Active on the project 5) Not overloaded 6) Reasonably low latency 7) Active at this time of day Actual behaviour: git cl owners offers a selection of possible OWNERS, apparently at random, some of whom may be appropriate.
,
Aug 19 2016
My original idea for measuring specificity was just to rank higher reviewers who own the least number of overall files in the tree. That way, we know their ownership is specific to this CL. But then I considered the case where someone might be an OWNER for the whole of Blink and a very specific part of //content. They might be scored low for a CL against that part of //content because of their broad ownership of files elsewhere, even though in reality their specificity is very good. I have started wondering if OWNERS files are actually a useful input to the scoring function. Maybe purely scoring based on "do they have a recent history of reviewing CLs like this one" would be better. Then the problem reduces to coming up with a workable metric for CL similarity.
,
Sep 1 2016
,
Sep 4 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5 2017
I'm still interested in doing something about this. Since the transition to Gerrit we have reviewer information in the git history, which makes it a lot easier to construct the necessary database.
,
Sep 5
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 14
Good suggestions for the future. We'd love to move towards an entirely different OWNERS system that's better integrated with git/Gerrit. If we can prioritize that these would be good suggestions to incorporate there. Though having data on all the criteria you suggest is non-trivial. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ricea@chromium.org
, Aug 18 2016