New issue
Advanced search Search tips

Issue 638789 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

M53 build (branch number: 2785) doesn't compile

Project Member Reported by x...@chromium.org, Aug 18 2016

Issue description

Version: 53 (branch number: 2785)
OS: ChromeOS

Repro steps:
1. git checkout -b branch_2785 branch-heads/2785
2. gclient sync -j16
3. gn clean out/Debug
4. gn args out/Debug 
   - add is_component_build=true
         target_os="chromeos"
         use_goma=true
5. ninja -C out/Debug -j1000 chrome chrome_sandbox

It failed at compile time. Error message:
In file included from ../../third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp:36:
../../third_party/WebKit/Source/bindings/core/v8/V8Binding.h:911:90: error: no member named 'ConstructorBehavior' in namespace 'v8'
    return v8::Function::New(isolate->GetCurrentContext(), function, environment, 0, v8::ConstructorBehavior::kThrow).ToLocalChecked();
                                                                                     ~~~~^
../../third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp:187:112: error: no member named 'ConstructorBehavior' in namespace 'v8'
    if (!v8::Function::New(scriptState->context(), V8LazyEventListenerToString, v8::Local<v8::Value>(), 0, v8::ConstructorBehavior::kThrow).ToLocal(&toStringFunction))
                                                                                                           ~~~~^


Revert the CL https://codereview.chromium.org/2124183003/ fixed the problem. 

jochen@, could you take a look at it? Thanks!

 

Comment 1 by jochen@chromium.org, Aug 22 2016

it's not possible to build a branch like this, see https://www.chromium.org/developers/how-tos/get-the-code/working-with-release-branches

Comment 2 by jochen@chromium.org, Aug 22 2016

Status: WontFix (was: Assigned)

Sign in to add a comment