New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638761 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 637754



Sign in to add a comment

WebRTC loopback video is not workin for VP8 and H264

Project Member Reported by avkodipelli@chromium.org, Aug 17 2016

Issue description

As there is some tool related issue, we are unable to run webrtc loopback video for few devices for VP8 and H264 video. 

This issue is tracking in github bug https://github.com/webrtc/apprtc/issues/350

We're filing this for tracking this bug in ChromeOS.
 
Cc: wuchengli@chromium.org posciak@chromium.org
Components: OS>Kernel>Video
+Video eng fyi...

Comment 2 by srcv@chromium.org, Aug 17 2016

Cc: jansson@chromium.org
Labels: -Type-Bug M-54 Type-Bug-Regression
+jansson@ who recently made some code changes to AppRTC.

As mentioned in this bug report, this issue is tracked in  https://github.com/webrtc/apprtc/issues/350
Blocking: 637754
Labels: videoshortlist
Cc: mflodman@chromium.org emir...@chromium.org magjed@chromium.org mcasas@chromium.org sprang@chromium.org
 Issue 637754  has been merged into this issue.
Cc: niklase@chromium.org
Labels: OS-Mac
Owner: jansson@chromium.org
jansson@, I think this is related to the Real AppRTC loopback change[0]. I tried older chrome versions and it still doesn't work. Munge SDP works.

AFAIU, this is issue happens because texture backed frames are sent back to the encode path after cloning tracks in the new loopback. We cannot use the texture backed frames, so we hit the DCHECK on[1]. Note that disabling HW decode would solve this issue as it is the reason why we have texture backed frames in the tracks.

1) jansson@, can you explain the change in AppRTC again? I do not understand why we would have the decoded frames back again for encoding?
2) If my understanding is right, can we have the old AppRTC back as an option? debug=1pcloopback?
3) posciak@,wuchengli@ this is the same reason as issue 550638. Should we handle it by downloading the textures?

[0] https://groups.google.com/a/google.com/forum/#!topic/webrtc-eng/bKdhZuwmiZQ
[1] https://cs.chromium.org/chromium/src/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc?q=webrtc_video_capturer_adapter.cc&sq=package:chromium&l=230
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
jansson@ Are you the right person for this? Any update? We use apprtc loopback for ChromeOS testing a lot.
AppRTC is now reverted to the old behavior. Still, this isn't a really a bug in AppRTC, the real problem is that we can forward hardware decoded video tracks.
Status: Fixed (was: Available)
As mentioned in #8 the old AppRTC loopback behavior is back for now. It will be relanded once all outstanding issues has been resolved.

Filed  bug 642663  for the "forward hardware decoded video tracks" issue.
Status: Verified (was: Fixed)
Verified 8530.77.0, 53.0.2785.87

Sign in to add a comment