Make downloads_api functions synchronous
Reported by
lo...@yandex-team.ru,
Aug 17 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2831.0 Safari/537.36 Steps to reproduce the problem: - What is the expected behavior? What went wrong? - Did this work before? N/A Chrome version: 54.0.2831.0 Channel: canary OS Version: 6.3 Flash Version: Shockwave Flash 22.0 r0 Async functions without SendResult look incorrect. I wrote some simple tests. They didn't pass.
,
Aug 18 2016
As per the provided CL from above comment cc'ing to @benjhayden for more updates on this bug.
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b54851675b93b91ab49f0581e616bd4804ff2af commit 4b54851675b93b91ab49f0581e616bd4804ff2af Author: lof84 <lof84@yandex-team.ru> Date: Thu Aug 18 16:39:52 2016 Make downloads_api functions synchronous Async functions without SendResult look incorrect. Made them synchronous and wrote tests. BUG= 638754 R=benjhayden@chromium.org Review-Url: https://codereview.chromium.org/2252233002 Cr-Commit-Position: refs/heads/master@{#412854} [modify] https://crrev.com/4b54851675b93b91ab49f0581e616bd4804ff2af/chrome/browser/extensions/api/downloads/downloads_api.cc [modify] https://crrev.com/4b54851675b93b91ab49f0581e616bd4804ff2af/chrome/browser/extensions/api/downloads/downloads_api.h [modify] https://crrev.com/4b54851675b93b91ab49f0581e616bd4804ff2af/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
,
Aug 19 2016
I think it's fixed.
,
Aug 19 2016
lof84@Could you please confirm whether we can close this issue as per comment #4.
,
Aug 19 2016
Yes, we can close this issue.
,
Aug 22 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lo...@yandex-team.ru
, Aug 17 2016