New issue
Advanced search Search tips

Issue 638748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 624991



Sign in to add a comment

black screen on startup when maximized with force-device-scale-factor on

Project Member Reported by bsep@chromium.org, Aug 17 2016

Issue description

Repros on 54.0.2831.0 (Official Build) canary (64-bit)

This is basically the same as  bug 625076  but it only happens if you have force-device-scale-factor on. It has to be a different scale factor than the "correct" one too, e.g. 2x when the monitor is set to 1.5x.
 
Blocking: 625076
Blocking: -625076 624991
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbaec91aacdd72f3f2941ff3f7b7706100d5081e

commit cbaec91aacdd72f3f2941ff3f7b7706100d5081e
Author: robliao <robliao@chromium.org>
Date: Thu Aug 18 22:07:27 2016

Check Content Window Visibility in DesktopNativeWidgetAura::IsVisible

Since DesktopNativeWidgetAura shows both the window tree host and the
content window in DesktopNativeWidgetAura::Show, it stands to reason
that DesktopNativeWidgetAura::IsVisible should also check both for
visibility.

Because Windows may show the Chrome window on its own before
BrowserView::Show is called, BrowserView::Show will assume everything
has been shown and just activate the window, failing to show the
content window. Adding in a content window visibility check provides
the actual visibility state of the window, even if it is intermediate.

BUG= 638748 

Review-Url: https://codereview.chromium.org/2256983003
Cr-Commit-Position: refs/heads/master@{#412949}

[modify] https://crrev.com/cbaec91aacdd72f3f2941ff3f7b7706100d5081e/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/cbaec91aacdd72f3f2941ff3f7b7706100d5081e/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment