New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638724 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Fix and re-enable v8.infinite_scroll benchmarks on Windows

Project Member Reported by eakuefner@chromium.org, Aug 17 2016

Issue description

The v8.infinite_scroll benchmarks are causing issues on Windows (both ignition and non-ignition). It appears that the Facebook page is specifically problematic.

Example first failing build: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf%20%281%29/builds/4081

I'm going to disable these two benchmarks on Windows. To debug this issue, trying to run the Facebook page on a Windows box (by passing --story-filter=facebook when running run_benchmark) would be a good place to start.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11ba3bbd5819de5705c63a5c9df639bcbaa38c71

commit 11ba3bbd5819de5705c63a5c9df639bcbaa38c71
Author: eakuefner <eakuefner@chromium.org>
Date: Thu Aug 18 00:24:30 2016

[BotHealth] Disable v8.infinite_scroll benchmarks on Windows

BUG= 638724 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2256853002
Cr-Commit-Position: refs/heads/master@{#412704}

[modify] https://crrev.com/11ba3bbd5819de5705c63a5c9df639bcbaa38c71/tools/perf/benchmarks/v8.py

Cc: hpayer@chromium.org rmcilroy@chromium.org
Labels: -Pri-3 Pri-2
Owner: u...@chromium.org
Status: Assigned (was: Untriaged)
Looks like the whole benchmark needs some love. Do we still need them though, I think we already have upgraded ones?
The logs also get spammed with messages containtin "Error: double-handled event  50808 50808 [object Object]"
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 31 2016

Mergedinto: 638625
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection
Author  : yoichio
Commit description:
  
This CL is updated of reverted one:
https://codereview.chromium.org/2001993002

This CL considers the reverted shadow boundary issue.

BUG= 481985 

Review-Url: https://codereview.chromium.org/2021793002
Cr-Commit-Position: refs/heads/master@{#412457}
Commit  : 08acdf950e1776571def8e6f16c288769e7e9e27
Date    : Wed Aug 17 06:16:52 2016


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N   Good?
chromium@412450  0          N/A      20  good
chromium@412455  0          N/A      20  good
chromium@412456  0          N/A      20  good
chromium@412457  1          N/A      20  bad    <--
chromium@412458  1          N/A      20  bad
chromium@412460  1          N/A      20  bad

Bisect job ran on: winx64_10_perf_bisect
Bug ID: 638724

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests v8.infinite_scroll_tbmv2
Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:peak_size_avg/discourse
Relative Change: Zero to non-zero
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_bisect/builds/701
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002891952338391280


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5299322382450688

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 7 by u...@chromium.org, Aug 31 2016

Status: Assigned (was: Duplicate)
I cannot reproduce the failure locally. Maybe it was fixed in the meantime. I'll try to re-enable the benchmark.

Comment 8 by u...@chromium.org, Oct 12 2016

Status: Fixed (was: Assigned)
This was fixed long time ago.

Sign in to add a comment