New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638722 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

chrome://chrome should open About page

Project Member Reported by tbuck...@chromium.org, Aug 17 2016

Issue description

chrome://chrome should open MD Settings to the About page. Currently we show the old About page. chrome://help has already been switched to point at MD Settings.
 

Comment 1 by dbeam@chromium.org, Aug 18 2016

Cc: groby@chromium.org
Blocking: 671375
Labels: -Pri-2 Pri-1
Owner: tommycli@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4aed8758b516fb6b3e84a93ba7b303347415715

commit a4aed8758b516fb6b3e84a93ba7b303347415715
Author: tommycli <tommycli@chromium.org>
Date: Fri Jan 27 01:34:58 2017

MD Settings: Redirect chrome://chrome to MD About when MD Settings is on

BUG= 638722 

Review-Url: https://codereview.chromium.org/2654423002
Cr-Commit-Position: refs/heads/master@{#446525}

[modify] https://crrev.com/a4aed8758b516fb6b3e84a93ba7b303347415715/chrome/browser/browser_about_handler.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0844eead6025c71d51db860f4a0290ea32f7aea9

commit 0844eead6025c71d51db860f4a0290ea32f7aea9
Author: tommycli <tommycli@chromium.org>
Date: Tue Jan 31 18:45:24 2017

MD Settings: Redirect chrome://help and chrome://chrome to About page.

This CL redirects chrome://help and chrome://chrome to
chrome://settings/help. This already worked before, but did not update
the virtual URL displayed in the Omnibox.

This caused navigation problems when the user navigated within
Settings (i.e. went to chrome://help, navigate to People section, and
the displayed URL would stay on chrome://help).

This CL sets chrome://settings/help as the canonical About location.

BUG= 638722 , 662028 

Review-Url: https://codereview.chromium.org/2664063002
Cr-Commit-Position: refs/heads/master@{#447280}

[modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/browser_about_handler_unittest.cc
[modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/chrome_content_browser_client.cc

Sign in to add a comment