Autofill doesn't work on site |
|||||||
Issue descriptionVersion: M53dev OS: iOS9.3.x, iPhone6s Enable Sync, make sure autofill is set up on profile Go to http://kitandkaboodlepets.com/petsitting_reservation.asp Type letter of first name into "first name" field expected: - autofill suggestions for form actual: - nothing besides letter going into text box This form works correctly on desktop (Mac).
,
Aug 18 2016
It also suggests fields that I've typed in previously. Do we sync those previous suggestions between desktop and mobile?
,
Aug 18 2016
Hmm... this site works for me on Android (M52) and Linux (M52) ... but not iOS (M51 and M52). Zach, you're seeing autocomplete=off?
,
Aug 18 2016
Yep. Screenshot attached. Interestingly, there is no server prediction for this field (which make sense). So I'm guessing it's an iOS regex problem. Adding in Lei who was working on these last. Are these all up to date now or...
,
Aug 18 2016
Could you please reassign if necessary.
,
Aug 18 2016
,
Aug 18 2016
I took a look at this. The issue with this site is that it has a huge form with 110 fields in it. And we refuse to deal with forms with more than 100 fields: https://cs.chromium.org/chromium/src/components/autofill/ios/browser/resources/autofill_controller.js?l=65-77 Is this limit something we'd be interested in relaxing?
,
Aug 18 2016
over to you zkoch... (thanks for tracking this down jdonnelly!)
,
Aug 18 2016
So that refusal is an iOS only refusal? I thought that was everywhere. If not, then yes, I agree we should lift the restriction. I don't know how high it should be though (150? 200? unlimited?).
,
Aug 18 2016
Looks like the limit is 200 on desktop (and Android?): https://cs.chromium.org/chromium/src/components/autofill/content/renderer/form_autofill_util.cc?l=55 I'd say we should go ahead and bump it up to match on iOS.
,
Aug 18 2016
+1 to bumping it up. This is probably because iOS split off back when the count was 100. r222920 bumped it up to 200 on the desktop, and we never matched it on iOS. After iOS upstreamed, we didn't notice this difference... until now.
,
Aug 18 2016
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/327f103c5a3498f7dcd59337e1facecb0774e301 commit 327f103c5a3498f7dcd59337e1facecb0774e301 Author: jdonnelly <jdonnelly@chromium.org> Date: Fri Aug 19 02:58:40 2016 Increase the autofill field limit when parsing forms to match desktop. These are meant to be kept in sync but the desktop value was increased at some point without increasing the limit here. BUG= 638720 Review-Url: https://codereview.chromium.org/2257973002 Cr-Commit-Position: refs/heads/master@{#413036} [modify] https://crrev.com/327f103c5a3498f7dcd59337e1facecb0774e301/components/autofill/ios/browser/resources/autofill_controller.js
,
Aug 19 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by zkoch@chromium.org
, Aug 17 2016