New issue
Advanced search Search tips

Issue 638716 link

Starred by 1 user
Status: Verified
Owner:
thestig@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

PDF crashes don't show the crashed URL

Project Member Reported by dsinclair@chromium.org, Aug 17 2016 
When a crash report comes in from the PDF process there is no URL reported. This makes it very difficult to track down PDF issues without a reproducing file.

Comment 1 by thestig@chromium.org, Aug 25 2016

Cc: -thestig@chromium.org
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: thestig@chromium.org
Probably regressed when we moved to out of process PPAPI. Into my queue it goes.

Comment 2 by karandeepb@chromium.org, Aug 26 2016

Status: Assigned (was: Untriaged)

Comment 3 by thestig@chromium.org, Sep 1 2016

Status: Started (was: Assigned)
We'll even record the page a PDF is on if it's embedded: https://codereview.chromium.org/2299943002/

Comment 4 by thestig@chromium.org, Sep 1 2016 

BTW, the WebContents that embeds the PDF plugin in the Chrome PDF Viewer does have the URL to the PDF in the subresource_url crash key. However, that WebContents rarely crashes.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/383ff955ecb5eddb6a91eae873f617f814426cc4

commit 383ff955ecb5eddb6a91eae873f617f814426cc4
Author: thestig <thestig@chromium.org>
Date: Thu Sep 08 07:12:16 2016

Record the PDF and top level URL when the PDF plugin crashes.

BUG= 638716 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2299943002
Cr-Commit-Position: refs/heads/master@{#417214}

[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/chrome/browser/extensions/api/streams_private/streams_private_api.cc
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/chrome/browser/resources/pdf/browser_api.js
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/chrome/browser/resources/pdf/pdf.js
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/pdf/out_of_process_instance.cc
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/c/private/ppb_pdf.h
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/cpp/private/pdf.cc
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/cpp/private/pdf.h
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/proxy/pdf_resource.cc
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/proxy/pdf_resource.h
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/thunk/ppb_pdf_api.h
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/thunk/ppb_pdf_thunk.cc

Comment 6 by thestig@chromium.org, Sep 8 2016

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/383ff955ecb5eddb6a91eae873f617f814426cc4

commit 383ff955ecb5eddb6a91eae873f617f814426cc4
Author: thestig <thestig@chromium.org>
Date: Thu Sep 08 07:12:16 2016

Record the PDF and top level URL when the PDF plugin crashes.

BUG= 638716 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2299943002
Cr-Commit-Position: refs/heads/master@{#417214}

[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/chrome/browser/extensions/api/streams_private/streams_private_api.cc
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/chrome/browser/resources/pdf/browser_api.js
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/chrome/browser/resources/pdf/pdf.js
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/pdf/out_of_process_instance.cc
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/c/private/ppb_pdf.h
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/cpp/private/pdf.cc
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/cpp/private/pdf.h
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/proxy/pdf_resource.cc
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/proxy/pdf_resource.h
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/thunk/ppb_pdf_api.h
[modify] https://crrev.com/383ff955ecb5eddb6a91eae873f617f814426cc4/ppapi/thunk/ppb_pdf_thunk.cc

Comment 8 by rookrishna@chromium.org, Apr 6 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment