New issue
Advanced search Search tips

Issue 638696 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[CVox Next] Tutorial Improvements

Project Member Reported by lpalmaro@chromium.org, Aug 17 2016

Issue description

I just went through the ChromeVox Next tutorial and have some feedback on how we can further improve the experience.  

1) Page titles: We should make the title of the page announce as you advance to the next page or go back to the previous one. This will give the user more context. 

2) In the jump commands page, we ask the user to ty pressing search H to go to next heading. Can we make a heading on this page so they can see what it's like? Right now, I just hear "no next heading" which is okay, but not ideal. 

3) On the page about accessing the command menu, it asks the user to press search + . to access the menus. Yet on this page, I can't actually open the menu. Is it possible to make the command menu accessible while the tutorial is open? 

4) On the last page of the tutorial (the Learn More page) we should make it so that the Next button is disabled, since there is no Next page. Same with the Previous button on the Welcome to ChromeVox Next! page. 

5) There are no visual focus states when using Tab on the buttons. Not a top priority, but just wanted to note this. 


 
Labels: -Pri-3 Tutorial Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97ee706900478132790e27b6ef7d689cf47583df

commit 97ee706900478132790e27b6ef7d689cf47583df
Author: dtseng <dtseng@chromium.org>
Date: Mon Nov 07 20:59:06 2016

Fix a variety of panel issues

- on blur, ensure state is set correctly (e.g. closed). Previously, alt tabbing away will keep the panel in a limbo state and un-re-openable
- fix tutorial:
1. page 7 was throwing an error because of a missing message string
2. the buttons to go to previous/next don't get disabled properly at each end of the set of pages
3. the title wasn't being announced, so users don't actually know anything happened when they moved in either direction. Make the heading focused when we generate the page
4. the page for command menus asks users to press search plus period. This exits the tutorial entirely and coming back jumps back to the beginning. Save the current viewed page and restore it every time for the current user session.
5. the tutorial doesn't have it's own keybinding.

BUG= 638696 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2480913002
Cr-Commit-Position: refs/heads/master@{#430373}

[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js
[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/common/command_store.js
[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.css
[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_command.js
[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
[modify] https://crrev.com/97ee706900478132790e27b6ef7d689cf47583df/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e765142cd8c54c3c082a1924f1c13b4ba18e59

commit 03e765142cd8c54c3c082a1924f1c13b4ba18e59
Author: dtseng <dtseng@chromium.org>
Date: Tue Nov 08 03:58:36 2016

Fix links in tutorial

This window doesn't actually allow browser navigation...so make sure it opens via chrome.windows.

The opened window places ChromeVox focus outside of the webView; ensure we're also treating the webView like a structural container (i.e. we automatically navigate into it and also ignore it when moving).

TEST=try clicking a link and ensure it actually works to open the page
BUG= 638696 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2480303003
Cr-Commit-Position: refs/heads/master@{#430512}

[modify] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
[modify] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd

Status: fixed (was: Assigned)
Status: Verified (was: Fixed)
verified on 56.0.2919.0

Sign in to add a comment