New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638693 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"virtual/threaded/animations/display-inline-style-adjust.html" is flakily crashing

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 17 2016

Issue description

"virtual/threaded/animations/display-inline-style-adjust.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjx2aXJ0dWFsL3RocmVhZGVkL2FuaW1hdGlvbnMvZGlzcGxheS1pbmxpbmUtc3R5bGUtYWRqdXN0Lmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: alancutter@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a8cd09c530df80c7dc4255d969f371ee44d654a

commit 0a8cd09c530df80c7dc4255d969f371ee44d654a
Author: Megan Jablonski <megjablon@google.com>
Date: Thu Aug 18 00:28:14 2016

Disable display-inline-style-adjust.html test

BUG= 638693 

Review URL: https://codereview.chromium.org/2256033002 .

Cr-Commit-Position: refs/heads/master@{#412707}

[modify] https://crrev.com/0a8cd09c530df80c7dc4255d969f371ee44d654a/third_party/WebKit/LayoutTests/TestExpectations

Strange, the failing builds reported by flakiness dashboard don't seem to be failing that test when looking into the individual build results.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests (with patch)&tests=virtual/threaded/animations/display-inline-style-adjust.html
Components: -Tests>Flaky Blink>Animation
Labels: -Pri-1 Update-Fortnightly OS-Mac Pri-2
Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4348e7c4eebcb3a47bd117bf96d5005070d77dc

commit a4348e7c4eebcb3a47bd117bf96d5005070d77dc
Author: johnme <johnme@chromium.org>
Date: Thu Aug 25 13:46:41 2016

Mark virtual/threaded/animations/display-inline-style-adjust.html flaky

Failed on builds 7051 7024 7022 7021 7000 6988 of
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29

Also failed on many linux builds and at least one Mac build:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Fanimations%2Fdisplay-inline-style-adjust.html

BUG= 638693 
NOTRY=true
NOTREECHECKS=true
TBR=alancutter@chromium.org

Review-Url: https://codereview.chromium.org/2278153002
Cr-Commit-Position: refs/heads/master@{#414421}

[modify] https://crrev.com/a4348e7c4eebcb3a47bd117bf96d5005070d77dc/third_party/WebKit/LayoutTests/TestExpectations

Looking at the windows failures the test is crashing with:

STDERR: [2816:3752:0821/130554:15798954:FATAL:blink_test_runner.cc(896)] Check failed: 0 != snapshot.info().width() (0 vs. 0)
STDERR: Backtrace:
STDERR: 	base::debug::StackTrace::StackTrace [0x01E9A257+23]
STDERR: 	logging::LogMessage::~LogMessage [0x01EE71BB+59]
STDERR: 	content::BlinkTestRunner::OnPixelsDumpCompleted [0x00D3A495+165]
STDERR: 	base::internal::FunctorTraits<void (__thiscall content::BlinkTestRunner::*)(SkBitmap const &),void>::Invoke<content::BlinkTestRunner *,SkBitmap const &> [0x00D32BE2+34]
STDERR: 	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BlinkTestRunner::*const &)(SkBitmap const &),content::BlinkTestRunner *,SkBitmap const &> [0x00D32DC5+53]
STDERR: 	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BlinkTestRunner::*)(SkBitmap const &),base::internal::UnretainedWrapper<content::BlinkTestRunner> >,void __cdecl(SkBitmap const &)>::RunImpl<void (__thiscall content::BlinkTestRun [0x00D32E48+72]
STDERR: 	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BlinkTestRunner::*)(SkBitmap const &),base::internal::UnretainedWrapper<content::BlinkTestRunner> >,void __cdecl(SkBitmap const &)>::Run [0x00D3BBC1+49]
STDERR: 	base::Callback<void __cdecl(SkBitmap const &),1>::Run [0x0DB04D9B+43]
STDERR: 	base::internal::BindState<void (__cdecl*)(std::unique_ptr<test_runner::`anonymous namespace'::PixelsDumpRequest,std::default_delete<test_runner::`anonymous namespace'::PixelsDumpRequest> >,SkBitmap const &),base::internal::PassedWrapper<std::unique_ptr<te [0x0DB046AF+175]
STDERR: 	base::internal::FunctorTraits<void (__cdecl*)(std::unique_ptr<test_runner::`anonymous namespace'::PixelsDumpRequest,std::default_delete<test_runner::`anonymous namespace'::PixelsDumpRequest> >,SkBitmap const &),void>::Invoke<std::unique_ptr<test_runner::` [0x0DB03434+36]
STDERR: 	base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl*const &)(std::unique_ptr<test_runner::`anonymous namespace'::PixelsDumpRequest,std::default_delete<test_runner::`anonymous namespace'::PixelsDumpRequest> >,SkBitmap const &),std::unique_ptr<test [0x0DB03521+49]
STDERR: 	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(std::unique_ptr<test_runner::`anonymous namespace'::PixelsDumpRequest,std::default_delete<test_runner::`anonymous namespace'::PixelsDumpRequest> >,SkBitmap const &),base::internal::PassedWr [0x0DB03616+70]
STDERR: 	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(std::unique_ptr<test_runner::`anonymous namespace'::PixelsDumpRequest,std::default_delete<test_runner::`anonymous namespace'::PixelsDumpRequest> >,SkBitmap const &),base::internal::PassedWr [0x0DB04E31+49]
STDERR: 	base::Callback<void __cdecl(SkBitmap const &),1>::Run [0x0DB04D9B+43]

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d22096aab9acd4d68600c93577b191c579ad99

commit 08d22096aab9acd4d68600c93577b191c579ad99
Author: johnme <johnme@chromium.org>
Date: Fri Aug 26 12:15:48 2016

Mark virtual/threaded/animations/display-inline-style-adjust.html crashy

Failed DCHECK on builds 7067 7054 7051 7024 7022 7021 7000 6988 of
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29

BUG= 638693 
NOTRY=true
NOTREECHECKS=true
TBR=alancutter@chromium.org

Review-Url: https://codereview.chromium.org/2283773002
Cr-Commit-Position: refs/heads/master@{#414689}

[modify] https://crrev.com/08d22096aab9acd4d68600c93577b191c579ad99/third_party/WebKit/LayoutTests/TestExpectations

Components: -Blink>Animation Internals>Skia>Compositing
Labels: -Update-Fortnightly OS-Windows
Owner: ----
Status: Available (was: Assigned)
Summary: "virtual/threaded/animations/display-inline-style-adjust.html" is flakily crashing (was: "virtual/threaded/animations/display-inline-style-adjust.html" is flaky)
Passing to Skia based on crash stack, please redirect if not appropriate.

The timeouts on non-Windows platforms may be due to the same issue.
Cc: reed@chromium.org
I don't see any failures since August 2016. I think this test is no longer flaking.

all_flake_occurrences.html
6.7 KB View Download
Project Member

Comment 12 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb6d3be1ab6a20735406528fecb19ec718ae110

commit 2fb6d3be1ab6a20735406528fecb19ec718ae110
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 16 02:09:01 2017

Remove flaky expectations for tests that no longer appear flaky.

Again, done with update-test-expectations.

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual/gpu/fast/canvas/painting-on-bad-canvas.html,fast/events/message-port-start-and-close-different-microtask.html,virtual/mojo-loading/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html,virtual/threaded/animations/display-inline-style-adjust.html,fast/selectors/007a.html,http/tests/workers/terminate-during-sync-operation-file.html,virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-file.html,virtual/threaded/inspector/tracing/decode-resize.html,external/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html,external/wpt/service-workers/service-worker/fetch-cors-xhr.https.html,external/wpt/service-workers/service-worker/fetch-csp.https.html,external/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html,external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html,external/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html,external/wpt/service-workers/service-worker/fetch-response-xhr.https.html,external/wpt/service-workers/service-worker/getregistrations.https.html,http/tests/security/link-crossorigin-preload-no-cors.html,virtual/mojo-loading/http/tests/inspector/tracing/timeline-script-parse.html,tables/mozilla/bugs/bug113424.html,fast/backgrounds/background-image-relative-url-in-iframe.html,crypto/subtle/worker-subtle-crypto-concurrent.html,fast/workers/termination-early.html,fast/dnd/dropEffect-for-effectAllowed.html

BUG= 404597 , 520174 , 520194 , 596752 , 619539 , 619539 , 638693 , 658997 ,664839, 678489 , 708934 , 713050 ,713419, 713509 , 713685 , 719298 

Review-Url: https://codereview.chromium.org/2884793002
Cr-Commit-Position: refs/heads/master@{#471981}

[modify] https://crrev.com/2fb6d3be1ab6a20735406528fecb19ec718ae110/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Available)

Sign in to add a comment