Issue metadata
Sign in to add a comment
|
"ToolbarActionViewInteractiveUITest.ActivateOverflowedToolbarActionWithKeyboard" is flaky |
||||||||||||||||||||||||
Issue description"ToolbarActionViewInteractiveUITest.ActivateOverflowedToolbarActionWithKeyboard" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWQsSBUZsYWtlIk5Ub29sYmFyQWN0aW9uVmlld0ludGVyYWN0aXZlVUlUZXN0LkFjdGl2YXRlT3ZlcmZsb3dlZFRvb2xiYXJBY3Rpb25XaXRoS2V5Ym9hcmQM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Aug 17 2016
,
Aug 17 2016
,
Aug 18 2016
This is probably also related to jonross@'s work on menus.
,
Aug 19 2016
Detected 6 new flakes for test/step "ToolbarActionViewInteractiveUITest.ActivateOverflowedToolbarActionWithKeyboard". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWQsSBUZsYWtlIk5Ub29sYmFyQWN0aW9uVmlld0ludGVyYWN0aXZlVUlUZXN0LkFjdGl2YXRlT3ZlcmZsb3dlZFRvb2xiYXJBY3Rpb25XaXRoS2V5Ym9hcmQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Aug 19 2016
Disabling the flaky test: https://codereview.chromium.org/2258953003/ -> out of sheriff queue
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65f860b243fd5b9938763473d4b346f8a5bce65d commit 65f860b243fd5b9938763473d4b346f8a5bce65d Author: treib <treib@chromium.org> Date: Fri Aug 19 11:59:36 2016 Disable flaky ToolbarActionViewInteractiveUITest.ActivateOverflowedToolbarActionWithKeyboard on Win TBR=rdevlin.cronin BUG= 638692 Review-Url: https://codereview.chromium.org/2258953003 Cr-Commit-Position: refs/heads/master@{#413109} [modify] https://crrev.com/65f860b243fd5b9938763473d4b346f8a5bce65d/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd6568bdc044afe156d1bf4bb29cb3be213d615a commit cd6568bdc044afe156d1bf4bb29cb3be213d615a Author: jonross <jonross@chromium.org> Date: Thu Aug 25 21:59:11 2016 Update Flaky ToolbarActionViewInteractiveUITests Update ActivateOverflowedToolbarActionWithKeyboard to block on final keyboard event, then clear the pending messages, before confirming the final state. Update TestContextMenuOnOverflowedAction. Remove the concept of the context menu callback, this is no longer needed with the menus not nesting message loops. Instead of posting tasks to the message loop in order to continue the test, they will be called directly. The message loop will still be ran until idle in order to allow for the processing of UI events. TEST= ToolbarActionViewInteractiveUITests.ActivateOverflowedToolbarActionWithKeyboard, ToolbarActionViewInteractiveUITests.TestContextMenuOnOverflowedAction BUG= 638692 , 639010 Review-Url: https://codereview.chromium.org/2259353002 Cr-Commit-Position: refs/heads/master@{#414549} [modify] https://crrev.com/cd6568bdc044afe156d1bf4bb29cb3be213d615a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/cd6568bdc044afe156d1bf4bb29cb3be213d615a/chrome/browser/ui/views/toolbar/toolbar_action_view.h [modify] https://crrev.com/cd6568bdc044afe156d1bf4bb29cb3be213d615a/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
,
Aug 27 2016
Detected 7 new flakes for test/step "ToolbarActionViewInteractiveUITest.ActivateOverflowedToolbarActionWithKeyboard". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWQsSBUZsYWtlIk5Ub29sYmFyQWN0aW9uVmlld0ludGVyYWN0aXZlVUlUZXN0LkFjdGl2YXRlT3ZlcmZsb3dlZFRvb2xiYXJBY3Rpb25XaXRoS2V5Ym9hcmQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Aug 29 2016
This has already been assigned -> removing Sheriff-Chromium
,
Aug 29 2016
The flakes I see for this are now the same timeouts as issue 639350 . Merging in.
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de3ca1335e0136092256b81cd3da9800c6d9c664 commit de3ca1335e0136092256b81cd3da9800c6d9c664 Author: Greg Thompson <grt@chromium.org> Date: Wed Nov 22 16:28:35 2017 Enable interactive_ui_tests on Windows that now run mostly reliably. r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG= 638692 , 764415 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: I6990772d1394cdb57545d818bd1c54af19f80c61 Reviewed-on: https://chromium-review.googlesource.com/784935 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#518652} [modify] https://crrev.com/de3ca1335e0136092256b81cd3da9800c6d9c664/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9ff92d24501a9b03e86649c6d68b254d8fead93 commit f9ff92d24501a9b03e86649c6d68b254d8fead93 Author: Dale Curtis <dalecurtis@chromium.org> Date: Wed Nov 22 19:33:06 2017 Revert "Enable interactive_ui_tests on Windows that now run mostly reliably." This reverts commit de3ca1335e0136092256b81cd3da9800c6d9c664. Reason for revert: Still flaking, https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64778 Original change's description: > Enable interactive_ui_tests on Windows that now run mostly reliably. > > r516772 was the last of many commits that resolved a number of problems > that made this test suite flaky on Windows. This CL enables tests that > had been disabled over time due to flakes, yet now seem to run okay. > > BUG= 638692 , 764415 > This CL was uploaded by git cl split. > > R=rdevlin.cronin@chromium.org > > Change-Id: I6990772d1394cdb57545d818bd1c54af19f80c61 > Reviewed-on: https://chromium-review.googlesource.com/784935 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518652} TBR=rdevlin.cronin@chromium.org,grt@chromium.org Change-Id: I8bce2de5ecd0c7a60cc383b447970a95423b3c96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 638692 , 764415 Reviewed-on: https://chromium-review.googlesource.com/786450 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#518709} [modify] https://crrev.com/f9ff92d24501a9b03e86649c6d68b254d8fead93/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4113a5c37315e331c50c97929444ce19916a8439 commit 4113a5c37315e331c50c97929444ce19916a8439 Author: Greg Thompson <grt@chromium.org> Date: Tue Nov 28 08:29:57 2017 Enable interactive_ui_tests on Windows that now run mostly reliably. r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG= 638692 , 764415 , 788112 This CL was uploaded by git cl split. Change-Id: I241701b1e72a6bbddb1051181235cd43e566393f Reviewed-on: https://chromium-review.googlesource.com/787230 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#519608} [modify] https://crrev.com/4113a5c37315e331c50c97929444ce19916a8439/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 17 2016