New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638672 link

Starred by 24 users

Issue metadata

Status: Fixed
Owner:
Left Chrome team
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Use play store app rather than website for fallback URLs

Project Member Reported by mariakho...@chromium.org, Aug 17 2016

Issue description

When a user pastes a URL in the omnibox that redirects to an intent, the redirect won't take effect due to our security policy of gesture-less intent redirects.

However, fallback URL is always http or https and cannot bring the user to play store the same way a redirect to intent with gesture would.

A couple of possibilities:
1) Consider PASTE in the omnibox as a user gesture
2) Automatically send fallback_urls that point to play.google.com to the installed play store rather than load in content area

 

Comment 1 by a...@branch.io, Aug 17 2016

I'd prefer 2.

One additional request with 2 is that you allow us to append Google Install Referrer params to the intent, or carry them through the web link. (related to this issue https://bugs.chromium.org/p/chromium/issues/detail?id=459711 where S.install_referrer was added)

Android referrer docs for info: https://developers.google.com/android/reference/com/google/android/gms/tagmanager/InstallReferrerReceiver

Comment 2 by dcolai...@gmail.com, Aug 31 2016

Bump. We are currently in this failure scenario and looking for a fix. As for the proposed solutions, keep in mind that this issue also occurs when the user chooses to launch a url from the 'Open in new tab' long press option, which might make Option 1 less of a catch all.

Comment 3 Deleted

Comment 4 by egr...@gmail.com, Nov 25 2016

Bump!!!!
Labels: M-57
I have a plan agreed with security team, for play.google.com fallback URL only to redirect to the play store instead of the play webpage. Will be making this fix in M-57.

Comment 6 by a...@branch.io, Nov 29 2016

Great! What's the ETA for this to hit production Chrome so we know when to update our code?
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41b288d33cad4776bc5f09ee435703a214449aaf

commit 41b288d33cad4776bc5f09ee435703a214449aaf
Author: mariakhomenko <mariakhomenko@chromium.org>
Date: Thu Dec 22 01:23:36 2016

Load Market App for Fallback URLs.

When handling a fallback URL for an app because the app is not
installed, if the app developer specified Play Store URL as a fallback
URL, then take the user to the Play Store App instead of loading the URL
in the browser.

BUG= 638672 

Review-Url: https://codereview.chromium.org/2595773002
Cr-Commit-Position: refs/heads/master@{#440297}

[modify] https://crrev.com/41b288d33cad4776bc5f09ee435703a214449aaf/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/41b288d33cad4776bc5f09ee435703a214449aaf/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Status: Fixed (was: Assigned)
The ETA for this to hit production is March 2017. The fix should be available on Chrome Canary in a day or so if you want to test it out.

Specifying fallback URL to be https://play.google.com/store/apps/details?id=<package>&referrer=code should redirect you to the play store app with the specified referrer.

Comment 9 by a...@branch.io, Dec 23 2016

You rock. Super pumped for this to not be so ghetto.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ec5b901da88d125dc7a441651d9926195070aa

commit 06ec5b901da88d125dc7a441651d9926195070aa
Author: mariakhomenko <mariakhomenko@chromium.org>
Date: Tue Jan 03 20:09:56 2017

Redirect to play store app for web play store URL fallback.

A fix for the initial implementation in
https://codereview.chromium.org/2595773002/ where we would only redirect
to play store in one of the cases where fallback URL is used. Move the
code to the general path for clobber instead.

BUG= 638672 

Review-Url: https://codereview.chromium.org/2608443003
Cr-Commit-Position: refs/heads/master@{#441199}

[modify] https://crrev.com/06ec5b901da88d125dc7a441651d9926195070aa/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/06ec5b901da88d125dc7a441651d9926195070aa/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Sign in to add a comment