New issue
Advanced search Search tips

Issue 638663 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature
TT



Sign in to add a comment

Lifecycle management of authpolicyd.

Project Member Reported by tnagel@chromium.org, Aug 17 2016

Issue description

After install attributes have been locked, only start authpolicyd for enterprise_ad device mode.  Before install attributes have been locked, only start authpolicyd once the user has started the enrollment flow.

See SessionManagerImpl::StartArcInstance() for example code.
 

Comment 1 by tnagel@chromium.org, Aug 17 2016

Labels: Enterprise-Triaged

Comment 2 by tnagel@chromium.org, Aug 17 2016

Probably the life cycle management should be brokered by session_manager.

Comment 3 by tnagel@chromium.org, Aug 19 2016

Labels: Type-Feature

Comment 4 by tnagel@chromium.org, Oct 24 2016

Summary: Start authpolicyd only after OOBE key combo has been pressed. (was: Start daemon only after OOBE key combo has been pressed.)

Comment 5 by tnagel@chromium.org, Oct 29 2016

Labels: -Pri-2 M-56 Pri-1
Summary: Lifetime management of authpolicyd. (was: Start authpolicyd only after OOBE key combo has been pressed.)

Comment 6 by tnagel@chromium.org, Oct 29 2016

Description: Show this description
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dbee9a85bbdda654daf71534ad3f02c2086588bd

commit dbee9a85bbdda654daf71534ad3f02c2086588bd
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Sat Oct 29 16:30:58 2016

authpolicy: Depend on libbrillo

Make authpolicy (R)DEPEND on libbrillo because authpolicyd is using
libinstallattributes.

BUG= chromium:638663 
TEST=manual

Change-Id: I89485965fcdd6f9044c571927589b1c39570d7d1
Reviewed-on: https://chromium-review.googlesource.com/405207
Commit-Ready: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/dbee9a85bbdda654daf71534ad3f02c2086588bd/chromeos-base/authpolicy/authpolicy-9999.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0f0a802753df88b2308d98b185dc2eba4d9bc068

commit 0f0a802753df88b2308d98b185dc2eba4d9bc068
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Mon Oct 24 13:08:00 2016

authpolicy: Gate startup on install attributes.

Prevent start after OOBE has been passed and install attributes don't
have enterprise_ad device mode.

BUG= chromium:638663 
TEST=manual
CQ-DEPEND=CL:405207

Change-Id: I8c77b2425d8f4df3d25f70723cff1345fa10c2f8
Reviewed-on: https://chromium-review.googlesource.com/400762
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/0f0a802753df88b2308d98b185dc2eba4d9bc068/authpolicy/authpolicy.cc
[modify] https://crrev.com/0f0a802753df88b2308d98b185dc2eba4d9bc068/authpolicy/authpolicy.gyp

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3cf1745cde76b1398bcb015f0e2b88fe89b2bff4

commit 3cf1745cde76b1398bcb015f0e2b88fe89b2bff4
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Mon Oct 31 13:05:58 2016

authpolicy: Remove unused #includes.

BUG= chromium:638663 
TEST=compilation succeeds

Change-Id: I367ef548dcb1664bb52984c296b5ac36629bc775
Reviewed-on: https://chromium-review.googlesource.com/405189
Commit-Ready: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/3cf1745cde76b1398bcb015f0e2b88fe89b2bff4/authpolicy/authpolicy.cc

Owner: rsorokin@chromium.org
Summary: Lifecycle management of authpolicyd. (was: Lifetime management of authpolicyd.)
Labels: TT
Labels: -M-56 M-57
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/72988d930964afe909d03b5d456fbdd71ee1acea

commit 72988d930964afe909d03b5d456fbdd71ee1acea
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Mon Nov 07 12:31:41 2016

authpolicy: Switch authpolicy to be started by Chromium

The authpolicy daemon should not be started every time on each device,
so Chromium would start it by D-BUS call on Active Directory devices only.

BUG= chromium:638663 
TEST=manual

Change-Id: Iab90cf29b339ec6fa0e70c5a8bfb28feb21d4047
Reviewed-on: https://chromium-review.googlesource.com/408237
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/72988d930964afe909d03b5d456fbdd71ee1acea/authpolicy/etc/dbus-1/org.chromium.AuthPolicy.conf
[modify] https://crrev.com/72988d930964afe909d03b5d456fbdd71ee1acea/authpolicy/etc/init/authpolicyd.conf

Status: Fixed (was: Started)
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bfc9e3eb223dca44ef3cf0b82832da7c27358eb

commit 3bfc9e3eb223dca44ef3cf0b82832da7c27358eb
Author: rsorokin <rsorokin@chromium.org>
Date: Thu Dec 01 14:03:12 2016

Start authpolicyd

Start in two places:
-On press custom shortcut (Ctrl-Alt-Shift-A) for the enrollment
-On reading install attributes in case it's Active Directory managed
device.

BUG= 638663 
TEST=manual

Review-Url: https://codereview.chromium.org/2530833002
Cr-Commit-Position: refs/heads/master@{#435603}

[modify] https://crrev.com/3bfc9e3eb223dca44ef3cf0b82832da7c27358eb/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/3bfc9e3eb223dca44ef3cf0b82832da7c27358eb/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Status: Verified (was: Fixed)

Sign in to add a comment