New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638656 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 638261



Sign in to add a comment

cheets_NotificationTest failure due to chrome browser crash in ARC launcher

Project Member Reported by domlasko...@chromium.org, Aug 17 2016

Issue description

android-sh failed to nsenter.


https://uberchromegw.corp.google.com/i/chromeos/builders/cyan-chrome-pfq/builds/58

08/17 09:13:06.793 ERROR|          parallel:0026| child process failed
08/17 09:13:06.860 DEBUG|          parallel:0030| Traceback (most recent call last):
08/17 09:13:06.860 DEBUG|          parallel:0030|   File "/usr/local/autotest/bin/parallel.py", line 18, in fork_start
08/17 09:13:06.861 DEBUG|          parallel:0030|     l()
08/17 09:13:06.861 DEBUG|          parallel:0030|   File "/usr/local/autotest/bin/job.py", line 463, in <lambda>
08/17 09:13:06.861 DEBUG|          parallel:0030|     l = lambda : test.runtest(self, url, tag, args, dargs)
08/17 09:13:06.862 DEBUG|          parallel:0030|   File "/usr/local/autotest/bin/test.py", line 117, in runtest
08/17 09:13:06.862 DEBUG|          parallel:0030|     job.sysinfo.log_after_each_iteration)
08/17 09:13:06.862 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 888, in runtest
08/17 09:13:06.863 DEBUG|          parallel:0030|     mytest._exec(args, dargs)
08/17 09:13:06.863 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 630, in _exec
08/17 09:13:06.863 DEBUG|          parallel:0030|     _cherry_pick_call(self.cleanup, *args, **dargs)
08/17 09:13:06.864 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/test.py", line 719, in _cherry_pick_call
08/17 09:13:06.864 DEBUG|          parallel:0030|     return func(*p_args, **p_dargs)
08/17 09:13:06.864 DEBUG|          parallel:0030|   File "/usr/local/autotest/common_lib/cros/arc.py", line 432, in cleanup
08/17 09:13:06.865 DEBUG|          parallel:0030|     raise error.TestFail(err)
08/17 09:13:06.865 DEBUG|          parallel:0030| TestFail: Command <android-sh -c 'cat > /data/misc/adb/adb_keys'> failed, rc=1, Command returned non-zero exit status
08/17 09:13:06.866 DEBUG|          parallel:0030| * Command: 
08/17 09:13:06.866 DEBUG|          parallel:0030|     android-sh -c 'cat > /data/misc/adb/adb_keys'
08/17 09:13:06.866 DEBUG|          parallel:0030| Exit status: 1
08/17 09:13:06.867 DEBUG|          parallel:0030| Duration: 0.0191121101379
08/17 09:13:06.867 DEBUG|          parallel:0030| 
08/17 09:13:06.867 DEBUG|          parallel:0030| stderr:
08/17 09:13:06.868 DEBUG|          parallel:0030| nsenter: cannot open /proc/20362/ns/ipc: No such file or directory

 
In the above 20362 is the android container process id.

There is also a chrome browser crash around this time, which could terminate the android container.

Cc: khmel@chromium.org
Status: Available (was: Untriaged)
Looking at /var/log/android.kmsg, the container indeed terminates due to a Chrome crash in the ARC launcher:


 0  chrome!aura::Window::HasObserver [observer_list.h : 188 + 0x0]
 1  chrome!aura::WindowObserver::OnUnobservingWindow [window_observer.cc : 25 + 0x8]
 2  chrome!aura::Window::RemoveObserver [window.cc : 489 + 0x8]
 3  chrome!AppWindowLauncherItemController::~AppWindowLauncherItemController [scoped_observer.h : 45 + 0x5]
 4  chrome!ArcAppWindowLauncherItemController::~ArcAppWindowLauncherItemController [arc_app_window_launcher_item_controller.cc : 25 + 0x13]
 5  chrome!ash::ShelfModel::RemoveShelfItemDelegate [unique_ptr.h : 76 + 0x6]
 6  chrome!ash::ShelfModel::RemoveItemAt [shelf_model.cc : 78 + 0xb]
 7  chrome!ChromeLauncherControllerImpl::CloseLauncherItem [chrome_launcher_controller_impl.cc : 363 + 0xa]
 8  chrome!ArcAppWindowLauncherController::UnregisterApp [arc_app_window_launcher_controller.cc : 603 + 0x3]
 9  chrome!ArcAppWindowLauncherController::OnTaskDestroyed [arc_app_window_launcher_controller.cc : 451 + 0xc]
10  chrome!ArcAppListPrefs::OnTaskDestroyed [arc_app_list_prefs.cc : 890 + 0xc]
11  chrome!arc::mojom::AppHostStub::Accept [app.mojom.cc : 4981 + 0x3]
trace.txt
154 KB View Download
Cc: skuhne@chromium.org
+skuhne

Recent changes in this area:

ARC: Show window title in launcher menu instead of app title
https://codereview.chromium.org/2243573002/

arc: Fix crash on Arc window close
https://codereview.chromium.org/2251493002/

The latter CL is included in the crashing chrome build, chrome 54.0.2831.0:
https://chromium.googlesource.com/chromium/src/+log/54.0.2830.0..54.0.2831.0?pretty=fuller&n=10000
Cc: -khmel@chromium.org
Owner: khmel@chromium.org
Status: Assigned (was: Available)

Comment 5 by khmel@chromium.org, Aug 17 2016

Status: Started (was: Assigned)
Summary: cheets_NotificationTest failure due to chrome browser crash in ARC launcher (was: cheets_NotificationTest failure on Cyan PFQ)
Seen on both veyron_minnie and cyan.

I can repro the crash with ToT chrome (54.0.2832.0 at revision 412659) by running in the chroot:

test_that -b veyron_minnie 172.18.37.37 cheets_Notification

The notification test app runs, some text fields are changed, then the window starts to close and the browser crashes while the window is partially transparent.

(Interestingly I see no notifications appear on the screen, even when I used an earlier build of chrome where the test passed.)

Comment 7 by khmel@chromium.org, Aug 17 2016

More likely one more race condition on close. Have fix locally, testing now
Cc: bccheng@chromium.org
Labels: Build-PFQ-Failures

Comment 11 by khmel@chromium.org, Aug 18 2016

Blockedon: 638261
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/800987eb69027f6f34dff840b19c68a83065c6ae

commit 800987eb69027f6f34dff840b19c68a83065c6ae
Author: khmel <khmel@chromium.org>
Date: Thu Aug 18 21:46:35 2016

arc: Fix crash on window close (on close race condition).

This handles race condition on window closing.

TEST=Extended browser_tests
TEST=Manually on device
TEST=test_that -b veyron_minnie <IP> cheets_Notification
BUG= 638656 
BUG= 638261 

Review-Url: https://codereview.chromium.org/2256273003
Cr-Commit-Position: refs/heads/master@{#412940}

[modify] https://crrev.com/800987eb69027f6f34dff840b19c68a83065c6ae/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/800987eb69027f6f34dff840b19c68a83065c6ae/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 19 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab778fe0ba6112332cdac7ff982364e8bba63ed

commit fab778fe0ba6112332cdac7ff982364e8bba63ed
Author: khmel <khmel@chromium.org>
Date: Fri Aug 19 22:58:22 2016

arc: Fix crash on window close (on close race condition).

This handles race condition on window closing.

TEST=Extended browser_tests
TEST=Manually on device
TEST=test_that -b veyron_minnie <IP> cheets_Notification
BUG= 638656 
BUG= 638261 

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2256273003
Cr-Commit-Position: refs/heads/master@{#412940}
(cherry picked from commit 800987eb69027f6f34dff840b19c68a83065c6ae)

Review-Url: https://codereview.chromium.org/2259403002
Cr-Commit-Position: refs/branch-heads/2785@{#689}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/fab778fe0ba6112332cdac7ff982364e8bba63ed/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/fab778fe0ba6112332cdac7ff982364e8bba63ed/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 14 by khmel@chromium.org, Aug 19 2016

Labels: -merge-merged-2785
Status: Fixed (was: Started)
 Issue 638657  has been merged into this issue.
Labels: VerifyIn-54
Status: Verified (was: Fixed)
Chrome OS 54.0.2840.15/8743.23.0

Sign in to add a comment