New issue
Advanced search Search tips

Issue 638655 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Android][Client] Remove cardboard code

Project Member Reported by yuweih@chromium.org, Aug 17 2016

Issue description

The cardboard code has long been abandoned but it is still being compiled and has dependencies on multiple active components, which gives us burden to maintain the obsolete code when doing refactoring.

Chromium is now deprecating the old cardboard SDK so we have no choice other than removing these code :(

We should still be able to revert the change and get back the cardboard code if we want to re-enable the functionality in the future.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788

commit 17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788
Author: yuweih <yuweih@chromium.org>
Date: Wed Aug 17 23:09:40 2016

[Remoting Android] Remove Cardboard Code

The cardboard code has long been abandoned but it is still being compiled and
has dependencies on multiple active components, which gives us burden to
maintain the obsolete code. The old cardboard SDK is also being deprecated so
we have no choice other than removing these code.

This CL removes the cardboard feature and the cardboard code.

BUG= 638655 

Review-Url: https://codereview.chromium.org/2252123002
Cr-Commit-Position: refs/heads/master@{#412683}

[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/android/BUILD.gn
[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/android/client_java_tmpl.gni
[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/android/java/AndroidManifest.xml.jinja2
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/res/layout/cardboard_desktop.xml
[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/android/java/res/menu/desktop_actionbar.xml
[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/android/java/src/org/chromium/chromoting/Desktop.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/CardboardRenderer.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/CardboardUtil.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/Cursor.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/Desktop.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/MenuBar.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/MenuItem.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/Photosphere.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/ShaderHelper.java
[delete] https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd/remoting/android/java/src/org/chromium/chromoting/cardboard/TextureHelper.java
[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/android/remoting_apk_tmpl.gni
[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/remoting_options.gni
[modify] https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788/remoting/resources/remoting_strings.grd

Comment 2 by yuweih@chromium.org, Aug 18 2016

Blocking: -627307 -638305
Status: Fixed (was: Assigned)

Sign in to add a comment