New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638642 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 643449
issue 643480



Sign in to add a comment

VR: Add ChromeVR to Chrome on Android

Project Member Reported by bshe@chromium.org, Aug 17 2016

Issue description

This could roughly divided into the following two steps:
1. Implement ChromeVR that can only be launched from Daydream Home app
2. Make Chrome aware of Daydream headset and automatically switch to ChromeVR when phone is inserted into a daydream headset.
To make it simple, ChromeVR currently has a floating quad in space. More UIs will be added later.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16e132a1b213a07254d25b50a42ba9e9304d3f75

commit 16e132a1b213a07254d25b50a42ba9e9304d3f75
Author: bshe <bshe@chromium.org>
Date: Sat Aug 27 10:38:15 2016

Introduce ChromeVR to Chrome on Android (behind a build flag)

This CL implements the following:
1. Adds a new activity called VrActivity. It extends from AsyncInitializationActivity
and can only be launched from Daydream app.
2. Adds a VrShell and its native part. VrShell has a GLSurfaceView as presentation
view for drawing left and right images and an inheriated(from GvrLayout) scanline
racing view(another GLSurfaceView).
3. Created a texture quad that is reserved for compositor to use to output content
frames. The quad is positioned at (0.0, 0.0, -1.0)

Known issue:
1. The quad is black as we haven't hookup a compositor to draw frames
2. tabs are not shared with ChromeTabbedActivity

To test this, add "enable_vr_shell=true" in your gn args.

BUG= 638642 

Review-Url: https://codereview.chromium.org/2252103002
Cr-Commit-Position: refs/heads/master@{#414890}

[modify] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/android/BUILD.gn
[modify] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/android/java/AndroidManifest.xml
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/android/java/src/org/chromium/chrome/browser/VrActivity.java
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/android/java_sources.gni
[modify] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/BUILD.gn
[modify] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/chrome_jni_registrar.cc
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/vr_shell/DEPS
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/vr_shell/vr_shell.cc
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/vr_shell/vr_shell.h
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/vr_shell/vr_shell_renderer.h
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/vr_shell/vr_util.cc
[add] https://crrev.com/16e132a1b213a07254d25b50a42ba9e9304d3f75/chrome/browser/android/vr_shell/vr_util.h

Blockedon: 643449
Blockedon: 643480
Components: UI>Browser>VR
Summary: VR: Add ChromeVR to Chrome on Android (was: Add ChromeVR to Chrome on Android)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a9e4415a09b41e101d84f8c129222cec0ecceb7

commit 6a9e4415a09b41e101d84f8c129222cec0ecceb7
Author: mthiesse <mthiesse@chromium.org>
Date: Tue Sep 13 15:31:05 2016

Refactor Vr activity into ChromeTabbedActivity.

This CL implements the following:
1. Deletes VrActivity, integrating VrShell into ChromeTabbedActivity.
2. Adds toggle for entering and exiting VR, simulating how NFC trigger
will work.

Known issues:
1. The current Compositor surface is displayed over top of the VR view.

To test this, add "enable_vr_shell=true" in your gn args.

These changes are pulled from our working experimental 'branch' found here: https://codereview.chromium.org/2248183002/

BUG= 638642 

Review-Url: https://codereview.chromium.org/2301633002
Cr-Commit-Position: refs/heads/master@{#418255}

[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/res/menu/main_menu.xml
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[delete] https://crrev.com/80cc8b1af214a4caba50a0a8794622b2103a2129/chrome/android/java/src/org/chromium/chrome/browser/VrActivity.java
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[add] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[add] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/android/java_sources.gni
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/ui_elements.cc
[add] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/ui_elements.h
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/vr_shell_renderer.h
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/vr_util.cc
[modify] https://crrev.com/6a9e4415a09b41e101d84f8c129222cec0ecceb7/chrome/browser/android/vr_shell/vr_util.h

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5584eb0f2c325d87582fa1f1d5a57cca1522f80b

commit 5584eb0f2c325d87582fa1f1d5a57cca1522f80b
Author: mthiesse <mthiesse@chromium.org>
Date: Wed Sep 21 00:58:54 2016

Implement new compositor and ContentViewCore reparenting for VR Shell.

BUG= 638642 

Review-Url: https://codereview.chromium.org/2319863005
Cr-Commit-Position: refs/heads/master@{#419927}

[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellInterface.java
[add] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java
[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/android/java_sources.gni
[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/browser/android/vr_shell/vr_compositor.cc
[add] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/browser/android/vr_shell/vr_compositor.h
[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/5584eb0f2c325d87582fa1f1d5a57cca1522f80b/chrome/browser/android/vr_shell/vr_shell.h

Labels: VR-FF
Labels: -Pri-3 -VR-FF VR-DF Pri-2
#2 is mostly working now; #1 can be addressed once we're closer to shipping.
In the context of a bug scrub:

Biao, can we close off this bug?  It doesn't look like this is tracking any one particular feature, and is instead covered by current launch bug(s).

Comment 11 by bshe@chromium.org, Aug 8 2017

Status: Fixed (was: Started)
Make sense. 

Sign in to add a comment