Issue 638641 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	ayatane@chromium.org
Closed:	Aug 2016
Cc:	xixuan@chromium.org ayatane@chromium.org █ jrbarnette@chromium.org
Components:	Infra>Client>ChromeOS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	----
VerifyIn-54 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Delete the logs on the DUT after they're copied to shard/drone.

Project Member Reported by xixuan@chromium.org, Aug 17 2016

Issue description

Now we don't delete the testing logs on the DUT, even if we have copied them to shard after testing. This have many disadvantages, like:

1. DUT can be full.

2. We cannot tell which testing logs have been copied, and which have not. If a copy process after a test fails, we don't know exactly which test it is.

3. The copy will use bandwidth between inside and outside of the lab.


We may delete the testing logs after copy them to shard/drone.

Comment 1 by jrbarnette@chromium.org, Aug 17 2016

Components: -Infra Infra>Client>ChromeOS
Owner: ayatane@chromium.org
Status: Assigned (was: Untriaged)

This is part of  bug 637935 .  Arguably, that bug has two parts,
and this is Part I, so maybe there should be two bugs.

Dumping this on ayatane@ to decide how to partition the work.

Comment 2 by ayatane@chromium.org, Aug 17 2016

Status: Started (was: Assigned)

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1641867d310df1ec429e72ac68630e2d6d0b8995

commit 1641867d310df1ec429e72ac68630e2d6d0b8995
Author: Allen Li <ayatane@chromium.org>
Date: Wed Aug 17 18:54:09 2016

[autotest] Remove crash files after copying

BUG= chromium:638641 , chromium:637935 
TEST=Run control file that forces core dumps

Change-Id: Ibe0ad43a568eca7fc0f13dc92d1183c0185804b3
Reviewed-on: https://chromium-review.googlesource.com/372458
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/1641867d310df1ec429e72ac68630e2d6d0b8995/server/crashcollect.py
[modify] https://crrev.com/1641867d310df1ec429e72ac68630e2d6d0b8995/server/site_crashcollect.py

Comment 4 by ayatane@chromium.org, Aug 25 2016

Status: Fixed (was: Started)

Comment 5 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5889a8a4cb7a9adf6d96934fe4d1e30411ce21c4

commit 5889a8a4cb7a9adf6d96934fe4d1e30411ce21c4
Author: Allen Li <ayatane@chromium.org>
Date: Wed Aug 17 18:54:09 2016

[autotest] Remove crash files after copying

Retry of https://chromium-review.googlesource.com/#/c/372458/ to fix
unintentionally removing files, for example, /var/log

Cleanup:

- Replace usage of stdout_tee=devnull with None.
- Move tmpdir removal into finally

BUG= chromium:638641 , chromium:637935 
TEST=Run control file that forces core dumps

Change-Id: If39b94510891fb507212d078609effc30efcb696
Reviewed-on: https://chromium-review.googlesource.com/376961
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/5889a8a4cb7a9adf6d96934fe4d1e30411ce21c4/server/crashcollect.py
[modify] https://crrev.com/5889a8a4cb7a9adf6d96934fe4d1e30411ce21c4/server/site_crashcollect.py