New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 638626 link

Starred by 2 users
Status: Fixed
Owner:
weili@chromium.org
Closed: Apr 2017
Cc:
█ rnimmagadda@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

PDF Display Issues

Reported by rwarring...@themxgroup.com, Aug 17 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Example URL:
—

Steps to reproduce the problem:
1. Open an interactive PDF within the browser

What is the expected behavior?
Interactive elements should be only be noticeable by rolling a mouse over (the cursors changes)

What went wrong?
All interactive elements have a light blue box over them — making legibility poor.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? Yes 

Chrome version: 52.0.2743.116  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by schenney@chromium.org, Aug 17 2016

Components: -Blink Internals>Plugins>PDF

Comment 2 by thestig@chromium.org, Aug 17 2016 

Please provide a sample PDF to illustrate the issue.

Comment 3 by rwarring...@themxgroup.com, Aug 17 2016 

No problem...

http://www.mavtechglobal.com/resources/pdfs/brochures/field-services-solutions.pdf

(This PDF was originally produced using Adobe Indesign)

Comment 4 by rnimmagadda@chromium.org, Aug 18 2016

Cc: rnimmagadda@chromium.org
Labels: M-53 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to repro this issue on Windows 7, MAC (10.11.5) & Ubuntu Trusty (14.04) for Google Chrome Stable Version - 52.0.2743.116

This is a Non-Regression issue existing from M30 - # 30.0.1549.0

Comment 5 by weili@chromium.org, Sep 22 2016

Owner: weili@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by weili@chromium.org, Apr 5 2017 

 Issue 707723  has been merged into this issue.

Comment 7 by weili@chromium.org, Apr 5 2017

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 8 2017 

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium_tests/+/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96

commit 7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96
Author: Wei Li <weili@chromium.org>
Date: Sat Apr 08 20:32:11 2017

Update corpus tests for correctly rendered push buttons

These tests all contain push buttons which were rendered lighter or had
extra layer of color. Correct them to the new expectations.

BUG= chromium:638626 

Change-Id: I4470fcec9a6cb83c47d6e22adb7684a6e48c635d
Reviewed-on: https://pdfium-review.googlesource.com/3810
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/js/submit_form_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/third_party/tcpdf/example_014_expected_win.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button1_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_3.5_part2/FRC_3.5_P__3648_Password_1_expected_win.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/action_run_javascript_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_8.4_part1/FRC_8.4.1_Annotations_AP_N_R.D__expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/layer/show_1_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_3.5_part2/FRC_3.5_P__3648_Password_1_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/action_execute_a_menu_item_expected_win.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/action_run_javascript_expected_win.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/form/form_same_expected.pdf.1.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/js/widget_javascript_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button10_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/form/event.changeex_expected_win.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_8.5_part2/FRC_8.5_U_GoToR_NewWindow_2_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/all_trigger_run_js_lunchurl_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/form/event.changeex_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/third_party/tcpdf/example_054_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_3.5_part2/FRC_3.5_P__3648_Password_1_expected_mac.pdf.0.png
[add] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/action_hide_show_form_expected_win.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/all_trigger_run_js_maildoc_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button8_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button3_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/form/open_a_weblink_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_8.5_part2/FRC_8.5_U_GoToR_NewWindow_expected_mac.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/third_party/tcpdf/example_014_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/third_party/tcpdf/example_054_expected_win.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/js/app_launchurl_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/image/bi_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/form/getarray_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_8.5_part2/FRC_8.5_U_GoToR_NewWindow_2_expected_mac.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button7_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button4_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_8.4_part1/FRC_8.4.1_Annotations_AP_N_R.D__expected_mac.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/form/form_same_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/action_hide_show_form_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button2_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button9_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/form/action_submit_a_form_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/FRC_8.5_part2/FRC_8.5_U_GoToR_NewWindow_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button0_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/action_reset_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/new/form/form_button5_expected.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/action_reset_expected_win.pdf.0.png
[modify] https://crrev.com/7c6a0e40f9e4f6f69f75adeae974f86f4ee98f96/fx/action/action_execute_a_menu_item_expected.pdf.0.png
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/cdb7e1f6adf0b6c0c2e2f9bedcb442292efbbab7

commit cdb7e1f6adf0b6c0c2e2f9bedcb442292efbbab7
Author: Wei Li <weili@chromium.org>
Date: Mon Apr 10 20:24:51 2017

Do not treat push button as fillable field

Only fillable fields should show highlights. Push button should
not do that. Doing so results in lighter color or extra layer of
light color.

BUG= chromium:638626 

Change-Id: I6b4d129e1f60bf44ff5a297d4b9db823d6be8079
Reviewed-on: https://pdfium-review.googlesource.com/3790
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>

[modify] https://crrev.com/cdb7e1f6adf0b6c0c2e2f9bedcb442292efbbab7/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
[modify] https://crrev.com/cdb7e1f6adf0b6c0c2e2f9bedcb442292efbbab7/DEPS
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c7ceb53a9c42839d8df044a6efa16aa01bfcda5

commit 9c7ceb53a9c42839d8df044a6efa16aa01bfcda5
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Tue Apr 11 17:43:08 2017

Roll src/third_party/pdfium/ 84b596d64..2d8b899e7 (13 commits)

https://pdfium.googlesource.com/pdfium.git/+log/84b596d64aab..2d8b899e77a7

$ git log 84b596d64..2d8b899e7 --date=short --no-merges --format='%ad %ae %s'
2017-04-11 dsinclair Remove the STREAMTYPE define.
2017-04-11 npm Avoid long assignment chain in FM parser
2017-04-11 dsinclair Remove unneeded stream access flags
2017-04-11 dsinclair Remove unused loading code from IFGAS_Stream
2017-04-11 dsinclair Disabiguate CreateStream calls
2017-04-10 dsinclair Guard against negative shift in nVal calculation
2017-04-10 dsinclair Remove unused CreateTextStream
2017-04-10 dsinclair Remove unused CreateSharedStream
2017-04-10 dsinclair Use checked_numeric to guard shift
2017-04-08 weili Do not treat push button as fillable field
2017-04-10 dsinclair Guard against negative shift in jbig2 huffman initialization
2017-04-10 dsinclair Fix windows skia component build
2017-04-07 tsepez Fix bytestring passing conventions, part 2.

Created with:
  roll-dep src/third_party/pdfium
BUG= 638626 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2815693002
Cr-Commit-Position: refs/heads/master@{#463675}

[modify] https://crrev.com/9c7ceb53a9c42839d8df044a6efa16aa01bfcda5/DEPS

Comment 11 by thestig@chromium.org, Apr 11 2017

Labels: -M-53
Status: Fixed (was: Started)

Comment 12 by ph...@kennedymonk.com, Apr 12 2017 

Hi guys,

Just wanted to post on here to say a massive thank you for fixing this so quickly and efficiently. I posted the bug report about the PDF buttons just over a week ago and its been brilliant to see you guys jump all over this and act so professionally.

You all deserve a medal.

THANK YOU! :)
ec4f8554e42e5d10e274cbe3d615c647_cat-meme-thank-you-memesuper-thank-you-cat-meme_500-295.jpeg
126 KB View Download
►

Sign in to add a comment