New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638621 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: ----

Blocked on:
issue 640245



Sign in to add a comment

video-buffered-range-contains-currentTime.html flaky on WebKit Win 7 bot

Project Member Reported by guidou@chromium.org, Aug 17 2016

Issue description

Comment 1 by guidou@chromium.org, Aug 17 2016

Labels: Sheriff-Chromium

Comment 2 by guidou@chromium.org, Aug 17 2016

Cc: foolip@chromium.org
Owner: srirama.m@chromium.org
Marking as flaky on Win7. https://codereview.chromium.org/2253953002/

srirama.m@: please take a look or find a better owner if necessary.

Comment 3 by guidou@chromium.org, Aug 17 2016

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03f0ab46684884cad5ff2f015c5846e6f884d8da

commit 03f0ab46684884cad5ff2f015c5846e6f884d8da
Author: guidou <guidou@chromium.org>
Date: Wed Aug 17 18:14:24 2016

Mark http/tests/media/video-buffered-range-contains-currentTime.html as flaky on Win7

TBR=foolip@chromium.org
BUG=638621

Review-Url: https://codereview.chromium.org/2253953002
Cr-Commit-Position: refs/heads/master@{#412587}

[modify] https://crrev.com/03f0ab46684884cad5ff2f015c5846e6f884d8da/third_party/WebKit/LayoutTests/TestExpectations

Blockedon: 640245
This is probably caused by  bug 620126 . Flakiness dashboard is broken so we are unable to check if it's still flaky.
Components: Build
Summary: video-buffered-range-contains-currentTime.html flaky on WebKit Win 7/Win 10 bot (was: video-buffered-range-contains-currentTime.html flaky on WebKit Win 7 bot)
Failing on WebKit Win10 bot too now:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/14739/steps/webkit_tests
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/14739/steps/webkit_tests/logs/stdio


It seems to fail constantly. Please try to rebaseline it.
Cc: srirama.m@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
I'll rebaseline it.
Cc: wangxianzhu@chromium.org
Labels: OS-Windows
Owner: mlamouri@chromium.org
Rebaseline didn't fix the problem. The test still failed on win_chromium_rel_ng after rebaseline:
https://storage.googleapis.com/chromium-layout-test-archives/win_chromium_rel_ng/292527/layout-test-results/results.html

Suspect the cause is https://chromium.googlesource.com/chromium/src/+/e04446d8dd30ead9e3e10f755a6becfedb03d8df.

mlamouri@ can you take a look?


Project Member

Comment 11 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e12c1373aef3f10d649fce395a8fe8ac36680db7

commit e12c1373aef3f10d649fce395a8fe8ac36680db7
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Sep 14 03:38:08 2016

Rebaseline tests for  bug 632548 ,  636222 , 638621

TBR=lazyboy@chromium.org
BUG= 632548 , 636222 ,638621

Review-Url: https://codereview.chromium.org/2332313003
Cr-Commit-Position: refs/heads/master@{#418476}

[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/fast/hidpi/video-controls-in-hidpi-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/fast/hidpi/video-controls-in-hidpi-expected.txt
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/fast/layers/video-layer-expected.txt
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/audio-controls-rendering-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/audio-repaint-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/controls-focus-ring-expected.txt
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.png
[add] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.txt
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/invalidation-after-opacity-change-subtree-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/overflow-scroll-body-appear-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/fast/hidpi/video-controls-in-hidpi-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/fast/hidpi/video-controls-in-hidpi-expected.txt
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/audio-controls-rendering-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/audio-repaint-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/controls-after-reload-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/controls-strict-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/controls-styling-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/controls-styling-strict-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/controls-without-preload-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/media-document-audio-repaint-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/video-controls-rendering-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/video-display-toggle-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/media/video-no-audio-expected.png
[modify] https://crrev.com/e12c1373aef3f10d649fce395a8fe8ac36680db7/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/compositing/text-match-highlight-expected.png
[delete] https://crrev.com/87b8f7c3fc3e5bbcc9601023df0fe79cb79234e8/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/invalidation-after-opacity-change-subtree-expected.png
[delete] https://crrev.com/87b8f7c3fc3e5bbcc9601023df0fe79cb79234e8/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/overflow-scroll-body-appear-expected.png

Cc: mlamouri@chromium.org
Components: -Build Blink>Media>Controls
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)
Summary: video-buffered-range-contains-currentTime.html flaky on WebKit Win 7 bot (was: video-buffered-range-contains-currentTime.html flaky on WebKit Win 7/Win 10 bot)
Owner: chcunningham@chromium.org
I'll take it. 

On my machine the test fails 4/5 times due to image differences. The tests goal is to immediately seek to the end of a media file. Sometimes the seek is issued quickly enough for most of the file to have not downloaded (doing only a range request for the last few milliseconds). When this occurs the seek bar is shown as mostly grayed out (rather than solid blue) because the bulk of the file is not buffered. 
@chcunningham , do you still intend to work on this?
I explored this in https://codereview.chromium.org/2439083003/

In that CL, I hit a wall because I tried to convert to using testharness.js only to realize it doesn't support pixel diff tests. Then it fell off my radar.

If you're interested, feel free to take it. Otherwise it will probably get very slow p3 treatment from me - pretty overloaded atm.
Status: Assigned (was: Available)

Sign in to add a comment