Migrate in_process_browser_test_browsertest.cc away from deprecated WebContentsObserver callback |
||||
Issue descriptionIn in_process_browser_test_browsertest.cc, LoadFailObserver currently listens for the DidFailProvisionalLoad() WebContentsObserver callback. However, these callbacks are deprecated and cannot be relied on when PlzNavigate is enabled. LoadFailObserver should migrate to listening for DidFinishNavigation(). This bug is the cause of the following browser_tests failures when run with PlzNavigate enabled: InProcessBrowserTest.ExternalConnectionFail
,
Sep 16 2016
,
Sep 16 2016
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd3181872bd0e0ee72e080e0c120049fd936718c commit cd3181872bd0e0ee72e080e0c120049fd936718c Author: yzshen <yzshen@chromium.org> Date: Mon Sep 19 16:20:02 2016 Change LoadFailObserver to use WebContentsObserver::DidFinishNavigation notification. This fixes the following browser test for PlzNavigate: InProcessBrowserTest.ExternalConnectionFail BUG= 638596 Review-Url: https://codereview.chromium.org/2349893002 Cr-Commit-Position: refs/heads/master@{#419477} [modify] https://crrev.com/cd3181872bd0e0ee72e080e0c120049fd936718c/chrome/test/base/in_process_browser_test_browsertest.cc
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddfbe6906e146026aae3335af2fb4c85bdbb6b51 commit ddfbe6906e146026aae3335af2fb4c85bdbb6b51 Author: yzshen <yzshen@chromium.org> Date: Mon Sep 19 18:16:57 2016 Update browser test filter for PlzNavigate. The corresponding fix is https://codereview.chromium.org/2349893002/ BUG= 638596 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2348233003 Cr-Commit-Position: refs/heads/master@{#419507} [modify] https://crrev.com/ddfbe6906e146026aae3335af2fb4c85bdbb6b51/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
,
Sep 19 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Aug 22 2016