Move WebAuthFlow away from deprecated WebContentsObserver methods |
|||||
Issue descriptionWebAuthFlow currently listens for the DidStartProvisionalLoadForFrame() and DidFailProvisionalLoad() WebContentsObserver callbacks. However, these callbacks are deprecated and cannot be relied on when PlzNavigate is enabled. WebAuthFlow should migrate to listening for DidStartNavigation() and DidFinishNavigation(). This bug is the cause of the following browser_tests failures when run with PlzNavigate enabled: LaunchWebAuthFlowFunctionTest.InteractiveFirstNavigationSuccess LaunchWebAuthFlowFunctionTest.NonInteractiveSuccess
,
Aug 22 2016
,
Sep 16 2016
,
Sep 16 2016
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e5f997391d09180d98f1d91cb1056f549341e15 commit 7e5f997391d09180d98f1d91cb1056f549341e15 Author: yzshen <yzshen@chromium.org> Date: Thu Sep 22 19:05:33 2016 Change WebAuthFlow to use the new WebContentsObserver navigation notifications. This fixes the following browser tests for PlzNavigate: LaunchWebAuthFlowFunctionTest.InteractiveFirstNavigationSuccess LaunchWebAuthFlowFunctionTest.NonInteractiveSuccess BUG= 638593 Review-Url: https://codereview.chromium.org/2342233004 Cr-Commit-Position: refs/heads/master@{#420415} [modify] https://crrev.com/7e5f997391d09180d98f1d91cb1056f549341e15/chrome/browser/extensions/api/identity/web_auth_flow.cc [modify] https://crrev.com/7e5f997391d09180d98f1d91cb1056f549341e15/chrome/browser/extensions/api/identity/web_auth_flow.h
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af50f33e45cccbb63c1d923b5ac5580853b43590 commit af50f33e45cccbb63c1d923b5ac5580853b43590 Author: yzshen <yzshen@chromium.org> Date: Thu Sep 22 20:56:00 2016 Update PlzNavigate browser test filter after WebAuthFlow fix. The corresponding fix is https://codereview.chromium.org/2342233004/ BUG= 638593 Review-Url: https://codereview.chromium.org/2345383002 Cr-Commit-Position: refs/heads/master@{#420455} [modify] https://crrev.com/af50f33e45cccbb63c1d923b5ac5580853b43590/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
,
Sep 22 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ajha@chromium.org
, Aug 22 2016