New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 638591 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 576285



Sign in to add a comment

PlzNavigate: Move NetErrorTabHelper away from deprecated WebContentsObserver methods

Project Member Reported by blundell@chromium.org, Aug 17 2016

Issue description

NetErrorTabHelper currently listens for the DidStartProvisionalLoadForFrame() and DidFailProvisionalLoad() WebContentsObserver callbacks. However, these callbacks are deprecated and cannot be relied on when PlzNavigate is enabled. NetErrorTabHelper should migrate to listening for DidStartNavigation() and DidFinishNavigation().

This bug is the cause of several browser_tests failures when run with PlzNavigate enabled:

DnsProbeBrowserTest.CorrectionsLoadStopped
DnsProbeBrowserTest.NoInternetProbeResultWithBrokenCorrections
ErrorPageNavigationCorrectionsFailTest.FetchCorrectionsFails
DnsProbeBrowserTest.NxdomainProbeResultWithWorkingSlowCorrections
ErrorPageTest.IFrameDNSError_JavaScript
DnsProbeBrowserTest.CorrectionsDisabled
DnsProbeBrowserTest.CorrectionsLoadStoppedSlowProbe
DnsProbeBrowserTest.ProbesDisabled
DnsProbeBrowserTest.SyncFailureWithBrokenCorrections
DnsProbeBrowserTest.NoInternetProbeResultWithSlowBrokenCorrections
DnsProbeBrowserTest.Incognito
DnsProbeBrowserTest.NxdomainProbeResultWithWorkingCorrections

 

Comment 1 by ajha@chromium.org, Aug 26 2016

Components: Tests
Cc: yzshen@chromium.org

Comment 3 by yzshen@chromium.org, Sep 16 2016

Owner: yzshen@chromium.org

Comment 4 by yzshen@chromium.org, Sep 16 2016

Blocking: 576285

Comment 5 by yzshen@chromium.org, Sep 16 2016

Owner: jam@chromium.org
Reassign to John since he is already working on this. Thanks, John!

Comment 6 by jam@chromium.org, Sep 23 2016

Status: Fixed (was: Available)

Comment 7 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 8 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment