New issue
Advanced search Search tips

Issue 638571 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::DepthOrderedLayoutObjectList::ordered

Project Member Reported by ClusterFuzz, Aug 17 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5041010575147008

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x611000284f28
Crash State:
  blink::DepthOrderedLayoutObjectList::ordered
  blink::FrameView::layoutOrthogonalWritingModeRoots
  blink::FrameView::performLayout
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=407480:407721

Minimized Testcase (0.81 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95vli4dZn3Z2mB4s3YZh6PgDyGt7ef9LK8eP04Xs_TvvlupSS-EfW1Gau64QIXzhZygoGrVSj3nB62Xfj3j5xqr46D6p9c1aI83lhbJ8mFe-gV5eLsg4uDtZAuocfKBAYVAI5C_L_oLLvbEAKfPvAgm290-ag?testcase_id=5041010575147008

Issue manually filed by: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, Aug 17 2016

Components: Blink>Layout
Labels: Pri-1
Owner: kojii@chromium.org
kojii@, I've seen that you fixed something pretty similar in  bug 588552 . Could you please take a look?
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 17 2016

Labels: M-54
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 17 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 17 2016

Status: Assigned (was: Untriaged)

Comment 5 by kojii@chromium.org, Aug 18 2016

Labels: -OS-Linux OS-All
Status: Started (was: Assigned)

Comment 6 by kojii@chromium.org, Aug 19 2016

Cc: e...@chromium.org
Project Member

Comment 7 by ClusterFuzz, Aug 19 2016

ClusterFuzz has detected this issue as fixed in range 412724:412741.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5041010575147008

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x611000284f28
Crash State:
  blink::DepthOrderedLayoutObjectList::ordered
  blink::FrameView::layoutOrthogonalWritingModeRoots
  blink::FrameView::performLayout
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=407480:407721
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=412724:412741

Minimized Testcase (0.81 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95vli4dZn3Z2mB4s3YZh6PgDyGt7ef9LK8eP04Xs_TvvlupSS-EfW1Gau64QIXzhZygoGrVSj3nB62Xfj3j5xqr46D6p9c1aI83lhbJ8mFe-gV5eLsg4uDtZAuocfKBAYVAI5C_L_oLLvbEAKfPvAgm290-ag?testcase_id=5041010575147008

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/119d9ebab5f2682ec5b3afe35ed078a80ae08635

commit 119d9ebab5f2682ec5b3afe35ed078a80ae08635
Author: kojii <kojii@chromium.org>
Date: Fri Aug 19 08:55:07 2016

Avoid LayoutFullScreen to be orthogonal writing-mode roots when reattached

The previous CL to avoid LayoutFullScreen to be orthogonal writing-mode
roots[1] copied the writing-mode when adding it to the parent. However,
when reattach occurs, LayoutTreeBuilder creates LayoutFullScreen
before the target is added to the parent, and thus LayoutFullScreen
fails to copy from the parent.

This patch copies the writing-mode when creating LayoutFullScreen.

[1] http://crrev.com/1721653002

BUG= 638571 

Review-Url: https://codereview.chromium.org/2258973002
Cr-Commit-Position: refs/heads/master@{#413089}

[add] https://crrev.com/119d9ebab5f2682ec5b3afe35ed078a80ae08635/third_party/WebKit/LayoutTests/fullscreen/orthogonal-writing-mode-full-screen-reattach-crash-expected.txt
[add] https://crrev.com/119d9ebab5f2682ec5b3afe35ed078a80ae08635/third_party/WebKit/LayoutTests/fullscreen/orthogonal-writing-mode-full-screen-reattach-crash.html
[modify] https://crrev.com/119d9ebab5f2682ec5b3afe35ed078a80ae08635/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[modify] https://crrev.com/119d9ebab5f2682ec5b3afe35ed078a80ae08635/third_party/WebKit/Source/core/layout/LayoutFullScreen.h
[modify] https://crrev.com/119d9ebab5f2682ec5b3afe35ed078a80ae08635/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/119d9ebab5f2682ec5b3afe35ed078a80ae08635/third_party/WebKit/Source/core/layout/LayoutObject.h

Project Member

Comment 9 by ClusterFuzz, Aug 19 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 19 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 25 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment