New issue
Advanced search Search tips

Issue 638553 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Unify duplicated test helpers for echoing heades (e.g. print-headers.cgi) in layout tests

Project Member Reported by tyoshino@chromium.org, Aug 17 2016

Issue description

This can be replaced with echo-requests.php
 
Components: -Blink Blink>Infra Tests
Labels: Test-Layout
Related: bug 347864. According to that bug, we want to move away from both Perl and PHP to use wptserve if possible.

Note: the files mentioned here are in LayoutTests/http/tests/xmlhttprequest/resources; there's currently no echo-requests.php but a echo-request-headers.php could be added based on echo-request-origin.php/echo-request-method.php.
These are the places where print-headers.cgi is still used:
  https://cs.chromium.org/search/?q=print-headers.cgi

tyoshino@, are you still planning to do this later?
Labels: -Type-Bug Hotlist-CodeHealth Type-Task
Owner: ----
Status: Available (was: Assigned)
Summary: Unify duplicated test helpers for echoing heades (e.g. print-headers.cgi) in layout tests (was: Delete print-headers.cgi in layout tests)
qyearsley: I filed this just for reducing duplicated files for the same purpose. So, moving to wptserve is fine and really good. I haven't done anything. I'll unassign myself for now. Feel free to work on this or assign someone else.
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 27 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by foolip@chromium.org, Apr 28 2018

Cc: robertma@chromium.org
Status: WontFix (was: Untriaged)
As expressed I think this is now a WontFix, both print-headers.cgi and echo-requests.php should ideally be migrated to wptserve. robertma@ has discussed enabling wptserve outside of external/wpt. That's a subset of issue 347864, so that might be a good issue to follow.

Sign in to add a comment