No bookmarks (and no bookmark button) are shown after update to M54. |
||||||
Issue descriptionUsers have no info about last visited dates for bookmarks when they update to M54. Previously, we show bookmarks button on NTP. Now, we show nothing before the user visits any bookmark. As a solution, introduce a special mode before we store any last visited dates for bookmarks. In this mode, - creation data for bookmarks is considered, - no age limit is imposed, - only 3 bookmarks are shown (configurable by Finch).
,
Aug 17 2016
This is addressed by CL 2256643002.
,
Aug 17 2016
Another feature request: Have this fallback to creation_date active only for 6 weeks after the user runs M54 for the first time. This way, we deal properly with users (e.g. from EM) that update to M54 much later than it is released.
,
Aug 18 2016
Un-assinging since Jan is OOO now. We'll see who picks it up :)
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a14bce74b74b8a043608b485dda1cb65191b24da commit a14bce74b74b8a043608b485dda1cb65191b24da Author: jkrcal <jkrcal@chromium.org> Date: Thu Aug 18 10:04:08 2016 Add a fallback to creation date for Recent bookmarks on NTP This fallback is active when we have less bookmarks with last visit info than specified by Finch (defaults to 3). This is relevant for existing users after they update to m54. In this fallback mode, we - use creation date instead of (missing) last visit date and - do not impose age limit on bookmarks to show BUG= 638538 Review-Url: https://codereview.chromium.org/2256643002 Cr-Commit-Position: refs/heads/master@{#412782} [modify] https://crrev.com/a14bce74b74b8a043608b485dda1cb65191b24da/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc [modify] https://crrev.com/a14bce74b74b8a043608b485dda1cb65191b24da/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h [modify] https://crrev.com/a14bce74b74b8a043608b485dda1cb65191b24da/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
,
Aug 19 2016
,
Aug 19 2016
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc5e1eb66477e2efba986ce9dff6be91258709bd commit dc5e1eb66477e2efba986ce9dff6be91258709bd Author: pke <pke@google.com> Date: Fri Aug 19 18:34:59 2016 Use bookmark creation date fallback for 6 weeks after installing M54 Add pref that stores the time the BookmarkSuggestionsProvider was first started on M54. Enable the creation_date_fallback only if that time is at most 6 weeks in the past. Fix minor nits from previous CL 2256643002/#ps20001. BUG= 638538 Review-Url: https://codereview.chromium.org/2256183004 Cr-Commit-Position: refs/heads/master@{#413193} [modify] https://crrev.com/dc5e1eb66477e2efba986ce9dff6be91258709bd/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/dc5e1eb66477e2efba986ce9dff6be91258709bd/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/dc5e1eb66477e2efba986ce9dff6be91258709bd/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc [modify] https://crrev.com/dc5e1eb66477e2efba986ce9dff6be91258709bd/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h [modify] https://crrev.com/dc5e1eb66477e2efba986ce9dff6be91258709bd/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc [modify] https://crrev.com/dc5e1eb66477e2efba986ce9dff6be91258709bd/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h [modify] https://crrev.com/dc5e1eb66477e2efba986ce9dff6be91258709bd/components/ntp_snippets/pref_names.cc [modify] https://crrev.com/dc5e1eb66477e2efba986ce9dff6be91258709bd/components/ntp_snippets/pref_names.h
,
Aug 20 2016
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea3816100645db1ab7c5e85ea52b5e5230264502 commit ea3816100645db1ab7c5e85ea52b5e5230264502 Author: treib <treib@chromium.org> Date: Tue Aug 23 17:15:50 2016 Bookmark Suggestions: Make 'creation date fallback' time configurable BUG= 638538 Review-Url: https://codereview.chromium.org/2275613002 Cr-Commit-Position: refs/heads/master@{#413766} [modify] https://crrev.com/ea3816100645db1ab7c5e85ea52b5e5230264502/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jkrcal@chromium.org
, Aug 17 2016