New issue
Advanced search Search tips

Issue 638536 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Build fails due to libusb deprecation warning in OSX 10.12

Project Member Reported by cos...@gmail.com, Aug 17 2016

Issue description

<b>Version: <Kenneth, what is the frequency?></b>
OS: 10.12 Beta (16A294a)

What steps will reproduce the problem?
(1) Get the OSX 10.12 public beta and XCode 8 beta 6.
(2) ninja -C out/Default chrome

What is the expected output?
A successful build.

What do you see instead?

FAILED: obj/third_party/libusb/libusb/darwin_usb.o 
../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/libusb/libusb/darwin_usb.o.d -DDEFAULT_VISIBILITY= -DHAVE_GETTIMEOFDAY=1 -DHAVE_POLL_H=1 -DHAVE_SYS_TIME_H=1 -DLIBUSB_DESCRIBE=\"1.0.16\" -DPOLL_NFDS_TYPE=nfds_t -DTHREADS_POSIX=1 -DOS_DARWIN=1 -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=277962-1 -DCR_XCODE_VERSION=0800 -DCOMPONENT_BUILD -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../../third_party/libusb/src/libusb/os -I../../third_party/libusb/src -I../.. -Igen -I../../third_party/libusb/src/libusb -fno-strict-aliasing -fstack-protector-strong -fcolor-diagnostics -arch x86_64 -O0 -gdwarf-2 -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.7 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-unused-function -std=c99 -c ../../third_party/libusb/src/libusb/os/darwin_usb.c -o obj/third_party/libusb/libusb/darwin_usb.o
../../third_party/libusb/src/libusb/os/darwin_usb.c:324:3: error: 'objc_registerThreadWithCollector' is deprecated: it does nothing. Define OBJC_SILENCE_GC_DEPRECATIONS=1 to temporarily silence this diagnostic. [-Werror,-Wdeprecated-declarations]
  objc_registerThreadWithCollector();
  ^
/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/objc/objc-auto.h:245:25: note: 'objc_registerThreadWithCollector' has been explicitly marked deprecated here
static OBJC_INLINE void objc_registerThreadWithCollector() { }
                        ^
1 error generated.

Please use labels and text to provide additional information.

I will upload a CL for this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f08e1fbbbff62e9d8fa8b985986dcefcbb481293

commit f08e1fbbbff62e9d8fa8b985986dcefcbb481293
Author: pwnall <pwnall@chromium.org>
Date: Wed Aug 17 20:15:43 2016

Make libusb deprecation warning go away on OSX 10.12.

BUG= 638536 

Review-Url: https://codereview.chromium.org/2253003002
Cr-Commit-Position: refs/heads/master@{#412628}

[modify] https://crrev.com/f08e1fbbbff62e9d8fa8b985986dcefcbb481293/third_party/libusb/BUILD.gn

Comment 2 by pwnall@chromium.org, Aug 18 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment