Issue metadata
Sign in to add a comment
|
Toggled checkbox state is not read by ChromeVox |
||||||||||||||||||||||||
Issue descriptionVersion: ToT OS: ChromeOS What steps will reproduce the problem? (1) Open Arc opt-in UI. (2) Move focus to checkbox by using ChromeVox navigation (Search+Shift+Arrow keys). (3) Toggle checkbox state by pressing space key. What is the expected output? ChromeVox should read the toggled checkbox state. What do you see instead? ChromeVox does not read the toggled checkbox state. This issue is caused by issue 638498 . We will fix this by avoiding the DOM structure as workaround.
,
Aug 17 2016
,
Aug 18 2016
CL has landed on master at https://crrev.com/2254673003
,
Aug 18 2016
,
Aug 18 2016
Request merge for M53.
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/359b23f1b3264cea0eac17380c45c200c5e5dd1f commit 359b23f1b3264cea0eac17380c45c200c5e5dd1f Author: yawano <yawano@chromium.org> Date: Thu Aug 18 04:06:54 2016 arc: avoid checkbox AutomationNode issue Avoid checkbox AutomationNode issue https://crbug.com/638498 BUG= 638501 BUG=b/30906810 TEST=tested as described in the issue CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2254673003 Cr-Commit-Position: refs/heads/master@{#412740} [modify] https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f/chrome/browser/resources/chromeos/arc_support/background.js [modify] https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f/chrome/browser/resources/chromeos/arc_support/main.css [modify] https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f/chrome/browser/resources/chromeos/arc_support/main.html
,
Aug 18 2016
Remove Merge-Request label for now. We are going to revert the CL. We will come back with fixed CL later.
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e420687328e28aa95ed2e6db3e83466dd5f398f commit 8e420687328e28aa95ed2e6db3e83466dd5f398f Author: yawano <yawano@chromium.org> Date: Thu Aug 18 08:14:23 2016 Revert of arc: avoid checkbox AutomationNode issue (patchset #1 id:1 of https://codereview.chromium.org/2254673003/ ) Reason for revert: https://crbug.com/638840 Original issue's description: > arc: avoid checkbox AutomationNode issue > > Avoid checkbox AutomationNode issue https://crbug.com/638498 > > BUG= 638501 > BUG=b/30906810 > TEST=tested as described in the issue > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f > Cr-Commit-Position: refs/heads/master@{#412740} TBR=xiyuan@chromium.org,khmel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 638501 Review-Url: https://codereview.chromium.org/2257073002 Cr-Commit-Position: refs/heads/master@{#412766} [modify] https://crrev.com/8e420687328e28aa95ed2e6db3e83466dd5f398f/chrome/browser/resources/chromeos/arc_support/background.js [modify] https://crrev.com/8e420687328e28aa95ed2e6db3e83466dd5f398f/chrome/browser/resources/chromeos/arc_support/main.css [modify] https://crrev.com/8e420687328e28aa95ed2e6db3e83466dd5f398f/chrome/browser/resources/chromeos/arc_support/main.html
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/359b23f1b3264cea0eac17380c45c200c5e5dd1f commit 359b23f1b3264cea0eac17380c45c200c5e5dd1f Author: yawano <yawano@chromium.org> Date: Thu Aug 18 04:06:54 2016 arc: avoid checkbox AutomationNode issue Avoid checkbox AutomationNode issue https://crbug.com/638498 BUG= 638501 BUG=b/30906810 TEST=tested as described in the issue CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2254673003 Cr-Commit-Position: refs/heads/master@{#412740} [modify] https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f/chrome/browser/resources/chromeos/arc_support/background.js [modify] https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f/chrome/browser/resources/chromeos/arc_support/main.css [modify] https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f/chrome/browser/resources/chromeos/arc_support/main.html
,
Aug 18 2016
I'll be out to Sep 2. fukino@ has kindly taken this issue for requesting merge to M53. Thank you so much!
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e2b1930480538185b0cef473949b586d96f4da2 commit 1e2b1930480538185b0cef473949b586d96f4da2 Author: yawano <yawano@chromium.org> Date: Thu Aug 18 17:53:48 2016 Reland: arc: avoid checkbox AutomationNode issue The original CL has caused https://crbug.com/638840 . This CL includes the fix to the issue in addition to the original CL. BUG= 638501 , 638840 BUG=b/30906810 TEST=tested as described in the issues. Original description: arc: avoid checkbox AutomationNode issue Avoid checkbox AutomationNode issue https://crbug.com/638498 BUG= 638501 BUG=b/30906810 TEST=tested as described in the issue CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f Cr-Commit-Position: refs/heads/master@{#412740} patch from issue 2254673003 at patchset 1 (http://crrev.com/2254673003#ps1) Review-Url: https://codereview.chromium.org/2259713003 Cr-Commit-Position: refs/heads/master@{#412887} [modify] https://crrev.com/1e2b1930480538185b0cef473949b586d96f4da2/chrome/browser/resources/chromeos/arc_support/background.js [modify] https://crrev.com/1e2b1930480538185b0cef473949b586d96f4da2/chrome/browser/resources/chromeos/arc_support/main.css [modify] https://crrev.com/1e2b1930480538185b0cef473949b586d96f4da2/chrome/browser/resources/chromeos/arc_support/main.html
,
Aug 23 2016
Requesting a merge for M53 as the proper fix has landed on main branch.
,
Aug 23 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29cbc1a0cd1822aef185b482a41ddd23e52251ca commit 29cbc1a0cd1822aef185b482a41ddd23e52251ca Author: Naoki Fukino <fukino@chromium.org> Date: Tue Aug 23 13:41:01 2016 Reland: arc: avoid checkbox AutomationNode issue The original CL has caused https://crbug.com/638840 . This CL includes the fix to the issue in addition to the original CL. BUG= 638501 , 638840 BUG=b/30906810 TEST=tested as described in the issues. TBR=xiyuan@chromium.org Original description: arc: avoid checkbox AutomationNode issue Avoid checkbox AutomationNode issue https://crbug.com/638498 BUG= 638501 BUG=b/30906810 TEST=tested as described in the issue CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f Cr-Commit-Position: refs/heads/master@{#412740} patch from issue 2254673003 at patchset 1 (http://crrev.com/2254673003#ps1) Review-Url: https://codereview.chromium.org/2259713003 Cr-Commit-Position: refs/heads/master@{#412887} (cherry picked from commit 1e2b1930480538185b0cef473949b586d96f4da2) Review URL: https://codereview.chromium.org/2274543002 . Cr-Commit-Position: refs/branch-heads/2785@{#723} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/29cbc1a0cd1822aef185b482a41ddd23e52251ca/chrome/browser/resources/chromeos/arc_support/background.js [modify] https://crrev.com/29cbc1a0cd1822aef185b482a41ddd23e52251ca/chrome/browser/resources/chromeos/arc_support/main.css [modify] https://crrev.com/29cbc1a0cd1822aef185b482a41ddd23e52251ca/chrome/browser/resources/chromeos/arc_support/main.html
,
Aug 24 2016
,
Sep 20 2016
verified on 53.0.2785.129 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by yawano@chromium.org
, Aug 17 2016