Issue metadata
Sign in to add a comment
|
Regression : On pressing 'Tab' key focus does not move in chrome://tracing page.
Reported by
mni...@etouch.net,
Aug 17 2016
|
||||||||||||||||||||||
Issue descriptionVersion : 53.0.2785.70 96e2feaa628dc2acd70404bf970fbdf18ec1bc2b-refs/branch-heads/2785@{#635} (64-bit) OS : Mac OS X(10.11.4,10.11.5) What steps will reproduce the problem? 1) Launch chrome and navigate to chrome://tracing/ 2) Now click on 'Record' button and record some activity. 3) Now click on 'Save' button an overlay gets open ,now press 'Tab' key from keyboard and observe the focus travel. Actual : On pressing 'Tab' key focus does not move on 'Cancel' and 'Ok' button Expected : On pressing 'Tab' key focus should move on 'Cancel' and 'Ok' button This is a regression issue broken in 'M-48' and below is the manual regression and Narrow bisect info: Good build : 48.0.2536.0 Bad build : 48.0.2537.0 Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/7307491ec4e471804e534c3603a495286dcb404e..c4303aeafc502565d7f2662eca7c2a385407f4ff?pretty=fuller&n=100 Suspecting : r354163 from Narrow bisect @avi : Could you please help to reassign if your change is not the cause for this change. Note : Issue is not seen on Linux and Windows OS
,
Aug 17 2016
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cd8a4ffe3f7262c8da2b7878c9766787afc09c8 commit 5cd8a4ffe3f7262c8da2b7878c9766787afc09c8 Author: avi <avi@chromium.org> Date: Wed Aug 17 20:04:07 2016 Force recalc of the keyloop for alerts. BUG= 638492 , 383820 TEST=javascript:prompt("hi") Review-Url: https://codereview.chromium.org/2252913003 Cr-Commit-Position: refs/heads/master@{#412622} [modify] https://crrev.com/5cd8a4ffe3f7262c8da2b7878c9766787afc09c8/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
,
Sep 29 2017
,
Sep 29 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by a...@chromium.org
, Aug 17 2016A much simpler repro is to type javascript:prompt("hi") into the omnibox.